Use uin8 instead of uint256 for status

This commit is contained in:
Amir Bandeali
2019-09-24 17:40:56 -07:00
parent 322a0a5967
commit e5aaf68277
3 changed files with 7 additions and 6 deletions

View File

@@ -19,6 +19,7 @@
pragma solidity ^0.5.9;
import "@0x/contracts-utils/contracts/src/LibRichErrors.sol";
import "../interfaces/IStructs.sol";
library LibStakingRichErrors {
@@ -113,9 +114,9 @@ library LibStakingRichErrors {
bytes4 internal constant POOL_EXISTENCE_ERROR_SELECTOR =
0x9ae94f01;
// bytes4(keccak256("InvalidStakeStatusError(uint256)"))
// bytes4(keccak256("InvalidStakeStatusError(uint8)"))
bytes4 internal constant INVALID_STAKE_STATUS_ERROR_SELECTOR =
0xb7161acd;
0x7cf20260;
// bytes4(keccak256("ProxyDestinationCannotBeNilError()"))
bytes internal constant PROXY_DESTINATION_CANNOT_BE_NIL_ERROR =
@@ -362,7 +363,7 @@ library LibStakingRichErrors {
);
}
function InvalidStakeStatusError(uint256 status)
function InvalidStakeStatusError(IStructs.StakeStatus status)
internal
pure
returns (bytes memory)

View File

@@ -287,7 +287,7 @@ contract MixinStake is
// invalid status
LibRichErrors.rrevert(
LibStakingRichErrors.InvalidStakeStatusError(uint256(status))
LibStakingRichErrors.InvalidStakeStatusError(status)
);
// required to compile ~ we should never hit this.