Default shouldValidate to true
This commit is contained in:
parent
0f8f5ca5ff
commit
e3bed5cc71
@ -148,7 +148,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrder: SignedOrder,
|
signedOrder: SignedOrder,
|
||||||
takerAssetFillAmount: BigNumber,
|
takerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrder', signedOrder, schemas.signedOrderSchema);
|
assert.doesConformToSchema('signedOrder', signedOrder, schemas.signedOrderSchema);
|
||||||
assert.isValidBaseUnitAmount('takerAssetFillAmount', takerAssetFillAmount);
|
assert.isValidBaseUnitAmount('takerAssetFillAmount', takerAssetFillAmount);
|
||||||
@ -191,7 +191,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrder: SignedOrder,
|
signedOrder: SignedOrder,
|
||||||
takerAssetFillAmount: BigNumber,
|
takerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrder', signedOrder, schemas.signedOrderSchema);
|
assert.doesConformToSchema('signedOrder', signedOrder, schemas.signedOrderSchema);
|
||||||
assert.isValidBaseUnitAmount('takerAssetFillAmount', takerAssetFillAmount);
|
assert.isValidBaseUnitAmount('takerAssetFillAmount', takerAssetFillAmount);
|
||||||
@ -239,7 +239,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrder: SignedOrder,
|
signedOrder: SignedOrder,
|
||||||
takerAssetFillAmount: BigNumber,
|
takerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrder', signedOrder, schemas.signedOrderSchema);
|
assert.doesConformToSchema('signedOrder', signedOrder, schemas.signedOrderSchema);
|
||||||
assert.isValidBaseUnitAmount('takerAssetFillAmount', takerAssetFillAmount);
|
assert.isValidBaseUnitAmount('takerAssetFillAmount', takerAssetFillAmount);
|
||||||
@ -286,7 +286,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
data: string,
|
data: string,
|
||||||
signature: string,
|
signature: string,
|
||||||
senderAddress: string,
|
senderAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.isBigNumber('salt', salt);
|
assert.isBigNumber('salt', salt);
|
||||||
assert.isETHAddressHex('signerAddress', signerAddress);
|
assert.isETHAddressHex('signerAddress', signerAddress);
|
||||||
@ -331,7 +331,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
takerAssetFillAmounts: BigNumber[],
|
takerAssetFillAmounts: BigNumber[],
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
_.forEach(takerAssetFillAmounts, takerAssetFillAmount =>
|
_.forEach(takerAssetFillAmounts, takerAssetFillAmount =>
|
||||||
@ -376,7 +376,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
makerAssetFillAmount: BigNumber,
|
makerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
assert.isBigNumber('makerAssetFillAmount', makerAssetFillAmount);
|
assert.isBigNumber('makerAssetFillAmount', makerAssetFillAmount);
|
||||||
@ -419,7 +419,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
takerAssetFillAmount: BigNumber,
|
takerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
assert.isBigNumber('takerAssetFillAmount', takerAssetFillAmount);
|
assert.isBigNumber('takerAssetFillAmount', takerAssetFillAmount);
|
||||||
@ -462,7 +462,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
makerAssetFillAmount: BigNumber,
|
makerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
assert.isBigNumber('makerAssetFillAmount', makerAssetFillAmount);
|
assert.isBigNumber('makerAssetFillAmount', makerAssetFillAmount);
|
||||||
@ -505,7 +505,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
takerAssetFillAmount: BigNumber,
|
takerAssetFillAmount: BigNumber,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
assert.isBigNumber('takerAssetFillAmount', takerAssetFillAmount);
|
assert.isBigNumber('takerAssetFillAmount', takerAssetFillAmount);
|
||||||
@ -548,7 +548,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
takerAssetFillAmounts: BigNumber[],
|
takerAssetFillAmounts: BigNumber[],
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
_.forEach(takerAssetFillAmounts, takerAssetFillAmount =>
|
_.forEach(takerAssetFillAmounts, takerAssetFillAmount =>
|
||||||
@ -593,7 +593,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signedOrders: SignedOrder[],
|
signedOrders: SignedOrder[],
|
||||||
takerAssetFillAmounts: BigNumber[],
|
takerAssetFillAmounts: BigNumber[],
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
assert.doesConformToSchema('signedOrders', signedOrders, schemas.signedOrdersSchema);
|
||||||
_.forEach(takerAssetFillAmounts, takerAssetFillAmount =>
|
_.forEach(takerAssetFillAmounts, takerAssetFillAmount =>
|
||||||
@ -633,7 +633,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
@decorators.asyncZeroExErrorHandler
|
@decorators.asyncZeroExErrorHandler
|
||||||
public async batchCancelOrdersAsync(
|
public async batchCancelOrdersAsync(
|
||||||
orders: Array<Order | SignedOrder>,
|
orders: Array<Order | SignedOrder>,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('orders', orders, schemas.ordersSchema);
|
assert.doesConformToSchema('orders', orders, schemas.ordersSchema);
|
||||||
assert.doesConformToSchema('orderTransactionOpts', orderTransactionOpts, orderTxOptsSchema, [txOptsSchema]);
|
assert.doesConformToSchema('orderTransactionOpts', orderTransactionOpts, orderTxOptsSchema, [txOptsSchema]);
|
||||||
@ -672,7 +672,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
leftSignedOrder: SignedOrder,
|
leftSignedOrder: SignedOrder,
|
||||||
rightSignedOrder: SignedOrder,
|
rightSignedOrder: SignedOrder,
|
||||||
takerAddress: string,
|
takerAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('leftSignedOrder', leftSignedOrder, schemas.signedOrderSchema);
|
assert.doesConformToSchema('leftSignedOrder', leftSignedOrder, schemas.signedOrderSchema);
|
||||||
assert.doesConformToSchema('rightSignedOrder', rightSignedOrder, schemas.signedOrderSchema);
|
assert.doesConformToSchema('rightSignedOrder', rightSignedOrder, schemas.signedOrderSchema);
|
||||||
@ -731,7 +731,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
signerAddress: string,
|
signerAddress: string,
|
||||||
signature: string,
|
signature: string,
|
||||||
senderAddress: string,
|
senderAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.isHexString('hash', hash);
|
assert.isHexString('hash', hash);
|
||||||
assert.isETHAddressHex('signerAddress', signerAddress);
|
assert.isETHAddressHex('signerAddress', signerAddress);
|
||||||
@ -887,7 +887,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
@decorators.asyncZeroExErrorHandler
|
@decorators.asyncZeroExErrorHandler
|
||||||
public async cancelOrderAsync(
|
public async cancelOrderAsync(
|
||||||
order: Order | SignedOrder,
|
order: Order | SignedOrder,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.doesConformToSchema('order', order, schemas.orderSchema);
|
assert.doesConformToSchema('order', order, schemas.orderSchema);
|
||||||
await assert.isSenderAddressAsync('order.maker', order.makerAddress, this._web3Wrapper);
|
await assert.isSenderAddressAsync('order.maker', order.makerAddress, this._web3Wrapper);
|
||||||
@ -922,7 +922,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
validatorAddress: string,
|
validatorAddress: string,
|
||||||
isApproved: boolean,
|
isApproved: boolean,
|
||||||
senderAddress: string,
|
senderAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.isETHAddressHex('validatorAddress', validatorAddress);
|
assert.isETHAddressHex('validatorAddress', validatorAddress);
|
||||||
assert.isBoolean('isApproved', isApproved);
|
assert.isBoolean('isApproved', isApproved);
|
||||||
@ -961,7 +961,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
|||||||
public async cancelOrdersUpToAsync(
|
public async cancelOrdersUpToAsync(
|
||||||
targetOrderEpoch: BigNumber,
|
targetOrderEpoch: BigNumber,
|
||||||
senderAddress: string,
|
senderAddress: string,
|
||||||
orderTransactionOpts: OrderTransactionOpts = {},
|
orderTransactionOpts: OrderTransactionOpts = { shouldValidate: true },
|
||||||
): Promise<string> {
|
): Promise<string> {
|
||||||
assert.isBigNumber('targetOrderEpoch', targetOrderEpoch);
|
assert.isBigNumber('targetOrderEpoch', targetOrderEpoch);
|
||||||
await assert.isSenderAddressAsync('senderAddress', senderAddress, this._web3Wrapper);
|
await assert.isSenderAddressAsync('senderAddress', senderAddress, this._web3Wrapper);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user