Refactor integration tests (CoordinatorTestFactory)

contracts/exchange/test/utils/constants.ts

@@ -24,6 +24,19 @@ export const constants = {
         ExchangeFunctionName.MarketBuyOrdersNoThrow,
         ExchangeFunctionName.MarketSellOrdersNoThrow,
     ],
+    MATCH_ORDER_FN_NAMES: [
+        ExchangeFunctionName.MatchOrders,
+        ExchangeFunctionName.MatchOrdersWithMaximalFill,
+    ],
+    BATCH_MATCH_ORDER_FN_NAMES: [
+        ExchangeFunctionName.BatchMatchOrders,
+        ExchangeFunctionName.BatchMatchOrdersWithMaximalFill,
+    ],
+    CANCEL_ORDER_FN_NAMES: [
+        ExchangeFunctionName.CancelOrder,
+        ExchangeFunctionName.BatchCancelOrders,
+        ExchangeFunctionName.CancelOrdersUpTo,
+    ],
 };
 
 export enum ValidatorWalletAction {

contracts/exchange/test/utils/exchange_data_encoder.ts

@@ -27,7 +27,7 @@ export const exchangeDataEncoder = {
                 orders.map(order => order[fillAsset]).reduce((prev, curr) => prev.plus(curr)),
                 orders.map(order => order.signature),
             );
-        } else if (fnName === ExchangeFunctionName.MatchOrders) {
+        } else if (exchangeConstants.MATCH_ORDER_FN_NAMES.indexOf(fnName) !== -1) {
             data = exchangeInstance.matchOrders.getABIEncodedTransactionData(
                 orders[0],
                 orders[1],

contracts/exchange/test/utils/types.ts

@@ -14,7 +14,7 @@ export enum ExchangeFunctionName {
     BatchFillOrders = 'batchFillOrders',
     BatchFillOrdersNoThrow = 'batchFillOrdersNoThrow',
     BatchMatchOrders = 'batchMatchOrders',
-    BatchMatchordersWithMaximalFill = 'batchMatchOrdersWithMaximalFill',
+    BatchMatchOrdersWithMaximalFill = 'batchMatchOrdersWithMaximalFill',
     CancelOrder = 'cancelOrder',
     CancelOrdersUpTo = 'cancelOrdersUpTo',
     ExecuteTransaction = 'executeTransaction',