All glory to the linter gods.

contracts/coordinator/test/coordinator.ts

@@ -113,21 +113,9 @@ describe('Coordinator tests', () => {
         const takerPrivateKey = devConstants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(takerAddress)];
         const feeRecipientPrivateKey = devConstants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(feeRecipientAddress)];
         orderFactory = new OrderFactory(makerPrivateKey, defaultOrderParams);
-        makerTransactionFactory = new TransactionFactory(
+        makerTransactionFactory = new TransactionFactory(makerPrivateKey, exchange.address, chainId);
-            makerPrivateKey,
+        takerTransactionFactory = new TransactionFactory(takerPrivateKey, exchange.address, chainId);
-            exchange.address,
+        approvalFactory = new ApprovalFactory(feeRecipientPrivateKey, coordinatorContract.address, chainId);
-            chainId,
-        );
-        takerTransactionFactory = new TransactionFactory(
-            takerPrivateKey,
-            exchange.address,
-            chainId,
-        );
-        approvalFactory = new ApprovalFactory(
-            feeRecipientPrivateKey,
-            coordinatorContract.address,
-            chainId,
-        );
     });
     beforeEach(async () => {
         await blockchainLifecycle.startAsync();

contracts/coordinator/test/mixins.ts

@@ -72,21 +72,9 @@ describe('Mixins tests', () => {
             devConstants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(transactionSignerAddress)];
         const approvalSignerPrivateKey1 = devConstants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(approvalSignerAddress1)];
         const approvalSignerPrivateKey2 = devConstants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(approvalSignerAddress2)];
-        transactionFactory = new TransactionFactory(
+        transactionFactory = new TransactionFactory(transactionSignerPrivateKey, exchangeAddress, chainId);
-            transactionSignerPrivateKey,
+        approvalFactory1 = new ApprovalFactory(approvalSignerPrivateKey1, mixins.address, chainId);
-            exchangeAddress,
+        approvalFactory2 = new ApprovalFactory(approvalSignerPrivateKey2, mixins.address, chainId);
-            chainId,
-        );
-        approvalFactory1 = new ApprovalFactory(
-            approvalSignerPrivateKey1,
-            mixins.address,
-            chainId,
-        );
-        approvalFactory2 = new ApprovalFactory(
-            approvalSignerPrivateKey2,
-            mixins.address,
-            chainId,
-        );
     });
     beforeEach(async () => {
         await blockchainLifecycle.startAsync();

contracts/coordinator/test/utils/approval_factory.ts

@@ -10,11 +10,7 @@ export class ApprovalFactory {
     private readonly _verifyingContractAddress: string;
     private readonly _chainId: number;
 
-    constructor(
+    constructor(privateKey: Buffer, verifyingContractAddress: string, chainId: number) {
-        privateKey: Buffer,
-        verifyingContractAddress: string,
-        chainId: number,
-    ) {
         this._privateKey = privateKey;
         this._verifyingContractAddress = verifyingContractAddress;
         this._chainId = chainId;

contracts/coordinator/test/utils/hash_utils.ts

@@ -30,7 +30,8 @@ export const hashUtils = {
                 transaction,
                 verifyingContractAddress,
                 txOrigin,
-                approvalExpirationTimeSeconds)
+                approvalExpirationTimeSeconds,
+            )
             .toString('hex')}`;
         return hashHex;
     },

contracts/exchange-libs/contracts/src/LibConstants.sol

@@ -38,7 +38,6 @@ contract LibConstants {
 
     bytes public ZRX_ASSET_DATA;
 
-
     /// @param zrxAssetData Asset data for ZRX token. Used for fee transfers.
     constructor (bytes memory zrxAssetData)
         public

contracts/exchange-libs/contracts/src/LibEIP712ExchangeDomain.sol

@@ -40,7 +40,6 @@ contract LibEIP712ExchangeDomain is
         );
     }
 
-
     /// @dev Calculates EIP712 encoding for a hash struct in the EIP712 domain
     ///      of the Exchange contract.
     /// @param hashStruct The EIP712 hash struct.

contracts/exchange-libs/contracts/test/TestLibs.sol

@@ -26,6 +26,7 @@ import "../src/LibFillResults.sol";
 import "../src/LibAbiEncoder.sol";
 
 
+// solhint-disable no-empty-blocks
 contract TestLibs is
     LibEIP712,
     LibMath,

contracts/exchange/contracts/src/MixinTransactions.sol

@@ -62,8 +62,7 @@ contract MixinTransactions is
                 salt,
                 signerAddress,
                 data
-           )
+        ));
-        );
 
         // Validate transaction has not been executed
         require(

contracts/exchange/contracts/test/TestSignatureValidator.sol

@@ -29,6 +29,7 @@ contract TestSignatureValidator is
     MixinTransactions
 {
 
+    // solhint-disable no-empty-blocks
     constructor (uint256 chainId)
         public
         LibEIP712(chainId)

contracts/exchange/test/match_orders.ts

@@ -122,7 +122,7 @@ describe('matchOrders', () => {
             provider,
             txDefaults,
             assetDataUtils.encodeERC20AssetData(zrxToken.address),
-            new BigNumber(chainId)
+            new BigNumber(chainId),
         );
         exchangeWrapper = new ExchangeWrapper(exchange, provider);
         await exchangeWrapper.registerAssetProxyAsync(erc20Proxy.address, owner);

contracts/exchange/test/transactions.ts

@@ -90,7 +90,7 @@ describe('Exchange transactions', () => {
             provider,
             txDefaults,
             assetDataUtils.encodeERC20AssetData(zrxToken.address),
-            new BigNumber(chainId)
+            new BigNumber(chainId),
         );
         exchangeWrapper = new ExchangeWrapper(exchange, provider);
         await exchangeWrapper.registerAssetProxyAsync(erc20Proxy.address, owner);
@@ -116,16 +116,8 @@ describe('Exchange transactions', () => {
         makerPrivateKey = constants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(makerAddress)];
         takerPrivateKey = constants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(takerAddress)];
         orderFactory = new OrderFactory(makerPrivateKey, defaultOrderParams);
-        makerTransactionFactory = new TransactionFactory(
+        makerTransactionFactory = new TransactionFactory(makerPrivateKey, exchange.address, chainId);
-            makerPrivateKey,
+        takerTransactionFactory = new TransactionFactory(takerPrivateKey, exchange.address, chainId);
-            exchange.address,
-            chainId,
-        );
-        takerTransactionFactory = new TransactionFactory(
-            takerPrivateKey,
-            exchange.address,
-            chainId,
-        );
     });
     describe('executeTransaction', () => {
         describe('fillOrder', () => {

contracts/exchange/test/utils/fill_order_combinatorial_utils.ts

@@ -103,7 +103,7 @@ export async function fillOrderCombinatorialUtilsFactoryAsync(
         provider,
         txDefaults,
         zrxAssetData,
-        new BigNumber(chainId)
+        new BigNumber(chainId),
     );
     const exchangeWrapper = new ExchangeWrapper(exchangeContract, provider);
     await exchangeWrapper.registerAssetProxyAsync(erc20Proxy.address, ownerAddress);
@@ -131,7 +131,7 @@ export async function fillOrderCombinatorialUtilsFactoryAsync(
         erc721Token,
         erc721Balances,
         exchangeContract.address,
-        chainId
+        chainId,
     );
 
     const testLibsContract = await TestLibsContract.deployFrom0xArtifactAsync(

contracts/exchange/test/utils/order_factory_from_scenario.ts

@@ -42,7 +42,7 @@ export class OrderFactoryFromScenario {
         erc721Token: DummyERC721TokenContract,
         erc721Balances: ERC721TokenIdsByOwner,
         exchangeAddress: string,
-        chainId: number
+        chainId: number,
     ) {
         this._userAddresses = userAddresses;
         this._zrxAddress = zrxAddress;

contracts/exchange/test/wrapper.ts

@@ -90,7 +90,7 @@ describe('Exchange wrappers', () => {
             provider,
             txDefaults,
             assetDataUtils.encodeERC20AssetData(zrxToken.address),
-            new BigNumber(chainId)
+            new BigNumber(chainId),
         );
         exchangeWrapper = new ExchangeWrapper(exchange, provider);
         await exchangeWrapper.registerAssetProxyAsync(erc20Proxy.address, owner);