Check fillable early

2018-08-17 14:19:19 -07:00 · 2018-08-17 14:19:19 -07:00 · b16f5f55fb
commit b16f5f55fb
parent d92fd43791
1 changed files with 6 additions and 0 deletions
--- a/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
+++ b/packages/contracts/src/2.0.0/protocol/Exchange/MixinExchangeCore.sol
@ -91,6 +91,12 @@ contract MixinExchangeCore is
        // Fetch order info
        OrderInfo memory orderInfo = getOrderInfo(order);
        
+        // An order can only be filled if its status is FILLABLE.
+        require(
+            orderInfo.orderStatus == uint8(OrderStatus.FILLABLE),
+            "ORDER_UNFILLABLE"
+        );
+
        // Fetch taker address
        address takerAddress = getCurrentContextAddress();