address comments

This commit is contained in:
Michael Zhu
2019-10-31 15:13:51 -07:00
parent 43e32f6a1a
commit af0de72bc3
2 changed files with 3 additions and 7 deletions

View File

@@ -10,7 +10,7 @@ import {
ExchangeFunctionName,
LocalBalanceStore,
} from '@0x/contracts-exchange';
import { blockchainTests, expect, hexConcat, hexSlice, verifyEvents } from '@0x/contracts-test-utils';
import { blockchainTests, constants, expect, hexConcat, hexSlice, verifyEvents } from '@0x/contracts-test-utils';
import { assetDataUtils, CoordinatorRevertErrors, orderHashUtils, transactionHashUtils } from '@0x/order-utils';
import { SignedOrder, SignedZeroExTransaction } from '@0x/types';
import { BigNumber } from '@0x/utils';
@@ -82,7 +82,7 @@ blockchainTests.resets('Coordinator integration tests', env => {
txReceipt: TransactionReceiptWithDecodedLogs,
msgValue?: BigNumber,
): LocalBalanceStore {
let remainingValue = msgValue || new BigNumber(0);
let remainingValue = msgValue || constants.ZERO_AMOUNT;
const localBalanceStore = LocalBalanceStore.create(balanceStore);
// Transaction gas cost
localBalanceStore.burnGas(txReceipt.from, DeploymentManager.gasPrice.times(txReceipt.gasUsed));

View File

@@ -116,11 +116,7 @@ blockchainTests.resets('FunctionAssertion Unit Tests', env => {
await assertion.executeAsync(message);
const expectedError = new StringRevertError(message);
return expect(
new Promise<Error>((_resolve, reject) => {
reject(sideEffectTarget);
}),
).to.revertWith(expectedError);
return expect(Promise.reject(sideEffectTarget!)).to.revertWith(expectedError); // tslint:disable-line
});
});
});