crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove lodash is undefined

Browse Source
This commit is contained in:
fragosti 2019-04-19 17:57:06 -05:00
parent d327fabf9c
commit a94b58e304
3 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/instant/src/components/instant_heading.tsx
View File

@ -38,7 +38,7 @@ export class InstantHeading extends React.PureComponent<InstantHeadingProps, {}>
private _renderAssetHeadingContent(): React.ReactNode { private _renderAssetHeadingContent(): React.ReactNode {
const { selectedAsset } = this.props; const { selectedAsset } = this.props;
if (_.isUndefined(selectedAsset)) { if (selectedAsset === undefined) {
// TODO: Only the ERC20 flow supports selecting assets. // TODO: Only the ERC20 flow supports selecting assets.
return this._renderERC20AssetHeading(); return this._renderERC20AssetHeading();
} }

3
packages/instant/src/components/zero_ex_instant_container.tsx
View File

@ -1,5 +1,4 @@
import { AssetProxyId } from '@0x/types'; import { AssetProxyId } from '@0x/types';
import * as _ from 'lodash';
import * as React from 'react'; import * as React from 'react';
import PoweredByLogo from '../assets/powered_by_0x.svg'; import PoweredByLogo from '../assets/powered_by_0x.svg';
@ -88,7 +87,7 @@ export class ZeroExInstantContainer extends React.PureComponent<
} }
private readonly _handleSymbolClick = (asset?: Asset): void => { private readonly _handleSymbolClick = (asset?: Asset): void => {
// TODO: If ERC721 link open sea or allow to choose another ERC721? // TODO: If ERC721 link open sea or allow to choose another ERC721?
if (_.isUndefined(asset) || asset.metaData.assetProxyId === AssetProxyId.ERC20) { if (asset === undefined || asset.metaData.assetProxyId === AssetProxyId.ERC20) {
analytics.trackTokenSelectorOpened(); analytics.trackTokenSelectorOpened();
this.setState({ this.setState({
tokenSelectionPanelAnimationState: 'slidIn', tokenSelectionPanelAnimationState: 'slidIn',

10
packages/instant/src/components/zero_ex_instant_provider.tsx
View File

@ -48,7 +48,8 @@ export class ZeroExInstantProvider extends React.PureComponent<ZeroExInstantProv
...defaultState.assetMetaDataMap, ...defaultState.assetMetaDataMap,
}; };
const selectedAsset = _.isUndefined(props.defaultSelectedAssetData) const selectedAsset =
props.defaultSelectedAssetData === undefined
? undefined ? undefined
: assetUtils.createAssetFromAssetDataOrThrow( : assetUtils.createAssetFromAssetDataOrThrow(
props.defaultSelectedAssetData, props.defaultSelectedAssetData,
@ -57,10 +58,9 @@ export class ZeroExInstantProvider extends React.PureComponent<ZeroExInstantProv
); );
let selectedAssetUnitAmount: BigNumber | undefined = new BigNumber(1); let selectedAssetUnitAmount: BigNumber | undefined = new BigNumber(1);
if (!_.isUndefined(selectedAsset) && selectedAsset.metaData.assetProxyId === AssetProxyId.ERC20) { if (selectedAsset !== undefined && selectedAsset.metaData.assetProxyId === AssetProxyId.ERC20) {
selectedAssetUnitAmount = _.isUndefined(props.defaultAssetBuyAmount) selectedAssetUnitAmount =
? undefined props.defaultAssetBuyAmount === undefined ? undefined : new BigNumber(props.defaultAssetBuyAmount);
: new BigNumber(props.defaultAssetBuyAmount);
} }
// construct the final state // construct the final state