crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2567 from 0xProject/fix/instanceof-array-isArray

Browse Source 
instanceof Array -> Array.isArray
This commit is contained in:
mzhu25 2020-04-28 01:03:02 -07:00 committed by GitHub
commit a90b463a7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/utils/CHANGELOG.json
View File

@ -13,6 +13,10 @@
{ {
"note": "`ZeroExRevertErrors.Migrate` -> `ZeroExRevertErrors.Ownable`", "note": "`ZeroExRevertErrors.Migrate` -> `ZeroExRevertErrors.Ownable`",
"pr": 2564 "pr": 2564
},
{
"note": "`instanceof Array` => `Array.isArray`",
"pr": 2567
} }
] ]
}, },

3
packages/utils/src/abi_encoder/abstract_data_types/types/set.ts
View File

@ -43,8 +43,7 @@ export abstract class AbstractSetDataType extends DataType {
} }
public generateCalldataBlock(value: any[] | object, parentBlock?: CalldataBlock): SetCalldataBlock { public generateCalldataBlock(value: any[] | object, parentBlock?: CalldataBlock): SetCalldataBlock {
const block = const block = Array.isArray(value)
value instanceof Array
? this._generateCalldataBlockFromArray(value, parentBlock) ? this._generateCalldataBlockFromArray(value, parentBlock)
: this._generateCalldataBlockFromObject(value, parentBlock); : this._generateCalldataBlockFromObject(value, parentBlock);
return block; return block;