crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/utils: Allow for array types in RevertError types.

Browse Source
This commit is contained in:
Lawrence Forman
2019-08-16 12:39:24 -04:00
parent 0fad6a6ec1
commit a3f6160898
3 changed files with 96 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
packages/utils/test/revert_error_test.ts
View File

@@ -21,6 +21,18 @@ class CustomRevertError extends RevertError {
}
}
class ArrayRevertError extends RevertError {
public constructor(strings?: string[]) {
super('ArrayRevertError', 'ArrayRevertError(string[] strings)', { strings });
}
}
class FixedSizeArrayRevertError extends RevertError {
public constructor(strings?: string[]) {
super('FixedArrayRevertError', 'FixedArrayRevertError(string[2] strings)', { strings });
}
}
RevertError.registerType(CustomRevertError);
describe('RevertError', () => {
@@ -41,6 +53,50 @@ describe('RevertError', () => {
const revert2 = new AnyRevertError();
expect(revert1.equals(revert2)).to.be.true();
});
it('should equate two revert errors with identical array fields', () => {
const strings = [ 'foo', 'bar' ];
const revert1 = new ArrayRevertError(strings);
const revert2 = new ArrayRevertError(strings);
expect(revert1.equals(revert2)).to.be.true();
});
it('should not equate two revert errors with different sized array fields', () => {
const strings = [ 'foo', 'bar' ];
const revert1 = new ArrayRevertError(strings);
const revert2 = new ArrayRevertError(strings.slice(0, 1));
expect(revert1.equals(revert2)).to.be.false();
});
it('should not equate two revert errors with different array field values', () => {
const strings1 = [ 'foo', 'bar' ];
const strings2 = [ 'foo', 'baz' ];
const revert1 = new ArrayRevertError(strings1);
const revert2 = new ArrayRevertError(strings2);
expect(revert1.equals(revert2)).to.be.false();
});
it('should equate two revert errors with identical fixed-size array fields', () => {
const strings = [ 'foo', 'bar' ];
const revert1 = new FixedSizeArrayRevertError(strings);
const revert2 = new FixedSizeArrayRevertError(strings);
expect(revert1.equals(revert2)).to.be.true();
});
it('should not equate two revert errors with different sized fixed-size array fields', () => {
const strings = [ 'foo', 'bar' ];
const revert1 = new FixedSizeArrayRevertError(strings);
const revert2 = new FixedSizeArrayRevertError(strings.slice(0, 1));
expect(revert1.equals(revert2)).to.be.false();
});
it('should not equate two revert errors with the wrong sized fixed-size array fields', () => {
const strings = [ 'foo', 'bar', 'baz' ];
const revert1 = new FixedSizeArrayRevertError(strings);
const revert2 = new FixedSizeArrayRevertError(strings);
expect(revert1.equals(revert2)).to.be.false();
});
it('should not equate two revert errors with different fixed-size array field values', () => {
const strings1 = [ 'foo', 'bar' ];
const strings2 = [ 'foo', 'baz' ];
const revert1 = new FixedSizeArrayRevertError(strings1);
const revert2 = new FixedSizeArrayRevertError(strings2);
expect(revert1.equals(revert2)).to.be.false();
});
it('should not equate a the same RevertError type with different values', () => {
const revert1 = new StringRevertError(message);
const revert2 = new StringRevertError(`${message}1`);