@0x/contract-staking: Address review nits.

`@0x/contracts-utils`: Use `safeDiv()` in `LibFractions.normalize()`.
2019-09-23 11:55:02 -04:00
parent 6d20f0e987
commit 9dd8c61a2f
4 changed files with 15 additions and 8 deletions
--- a/contracts/utils/contracts/src/LibFractions.sol
+++ b/contracts/utils/contracts/src/LibFractions.sol
@@ -64,7 +64,7 @@ library LibFractions {
        // re-scale them by `maxValue` to prevent overflows in future operations.
        if (numerator > maxValue || denominator > maxValue) {
            uint256 rescaleBase = numerator >= denominator ? numerator : denominator;
-            rescaleBase /= maxValue;
+            rescaleBase = rescaleBase.safeDiv(maxValue);
            scaledNumerator = numerator.safeDiv(rescaleBase);
            scaledDenominator = denominator.safeDiv(rescaleBase);
        } else {