crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Protocol fee amount is not enforced by staking contract

Browse Source
This commit is contained in:
Greg Hysen 2019-10-22 11:25:19 -07:00
parent 22e39f782f
commit 9ac715f99d
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
contracts/staking/contracts/src/fees/MixinExchangeFees.sol
View File

@ -161,15 +161,8 @@ contract MixinExchangeFees is
private private
view view
{ {
if (protocolFeePaid == 0) { // The protocol fee must equal the value passed to the contract; unless
LibRichErrors.rrevert( // the value is zero, in which case the fee is taken in WETH.
LibStakingRichErrors.InvalidProtocolFeePaymentError(
LibStakingRichErrors.ProtocolFeePaymentErrorCodes.ZeroProtocolFeePaid,
protocolFeePaid,
msg.value
)
);
}
if (msg.value != protocolFeePaid && msg.value != 0) { if (msg.value != protocolFeePaid && msg.value != 0) {
LibRichErrors.rrevert( LibRichErrors.rrevert(
LibStakingRichErrors.InvalidProtocolFeePaymentError( LibStakingRichErrors.InvalidProtocolFeePaymentError(

1
contracts/staking/contracts/src/libs/LibStakingRichErrors.sol
View File

@ -30,7 +30,6 @@ library LibStakingRichErrors {
} }
enum ProtocolFeePaymentErrorCodes { enum ProtocolFeePaymentErrorCodes {
ZeroProtocolFeePaid,
MismatchedFeeAndPayment MismatchedFeeAndPayment
} }