crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Wrap balancer fetch top pools with try and catch [TKR-481] (#515)

Browse Source 
* Wrap balancer fetch top pool with try and catch

* Update CHANGELOG.json
This commit is contained in:
Kyu 2022-07-12 13:50:07 -07:00 committed by GitHub
parent e77958425f
commit 982173471c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/asset-swapper/CHANGELOG.json
View File

@ -1,4 +1,13 @@
[ [
{
"version": "16.63.1",
"changes": [
{
"note": "Better error handling for balancer cache",
"pr": 515
}
]
},
{ {
"version": "16.63.0", "version": "16.63.0",
"changes": [ "changes": [

12
packages/asset-swapper/src/utils/market_operation_utils/pools_cache/balancer_utils.ts
View File

@ -2,6 +2,8 @@ import { getPoolsWithTokens, parsePoolData } from 'balancer-labs-sor-v1';
import { Pool } from 'balancer-labs-sor-v1/dist/types'; import { Pool } from 'balancer-labs-sor-v1/dist/types';
import { gql, request } from 'graphql-request'; import { gql, request } from 'graphql-request';
import { DEFAULT_WARNING_LOGGER } from '../../../constants';
import { LogFunction } from '../../../types';
import { BALANCER_MAX_POOLS_FETCHED, BALANCER_SUBGRAPH_URL, BALANCER_TOP_POOLS_FETCHED } from '../constants'; import { BALANCER_MAX_POOLS_FETCHED, BALANCER_SUBGRAPH_URL, BALANCER_TOP_POOLS_FETCHED } from '../constants';
import { CacheValue, PoolsCache } from './pools_cache'; import { CacheValue, PoolsCache } from './pools_cache';
@ -24,6 +26,7 @@ export class BalancerPoolsCache extends PoolsCache {
cache: { [key: string]: CacheValue } = {}, cache: { [key: string]: CacheValue } = {},
private readonly maxPoolsFetched: number = BALANCER_MAX_POOLS_FETCHED, private readonly maxPoolsFetched: number = BALANCER_MAX_POOLS_FETCHED,
private readonly _topPoolsFetched: number = BALANCER_TOP_POOLS_FETCHED, private readonly _topPoolsFetched: number = BALANCER_TOP_POOLS_FETCHED,
private readonly _warningLogger: LogFunction = DEFAULT_WARNING_LOGGER,
) { ) {
super(cache); super(cache);
void this._loadTopPoolsAsync(); void this._loadTopPoolsAsync();
@ -49,7 +52,14 @@ export class BalancerPoolsCache extends PoolsCache {
[from: string]: { [to: string]: Pool[] }; [from: string]: { [to: string]: Pool[] };
} = {}; } = {};
const pools = await this._fetchTopPoolsAsync(); let pools: BalancerPoolResponse[];
try {
pools = await this._fetchTopPoolsAsync();
} catch (err) {
this._warningLogger(err, 'Failed to fetch top pools for Balancer V1');
return;
}
for (const pool of pools) { for (const pool of pools) {
const { tokensList } = pool; const { tokensList } = pool;
for (const from of tokensList) { for (const from of tokensList) {

9
packages/asset-swapper/src/utils/market_operation_utils/pools_cache/balancer_v2_utils.ts
View File

@ -114,7 +114,14 @@ export class BalancerV2PoolsCache extends PoolsCache {
[from: string]: { [to: string]: Pool[] }; [from: string]: { [to: string]: Pool[] };
} = {}; } = {};
const pools = await this._fetchTopPoolsAsync(); let pools: BalancerPoolResponse[];
try {
pools = await this._fetchTopPoolsAsync();
} catch (err) {
this._warningLogger(err, 'Failed to fetch top pools for Balancer V2');
return;
}
for (const pool of pools) { for (const pool of pools) {
const { tokensList } = pool; const { tokensList } = pool;
for (const from of tokensList) { for (const from of tokensList) {