Address feedback

This commit is contained in:
Leonid Logvinov 2017-05-29 15:54:52 +02:00
parent fa156531bf
commit 7bd3d87f7a
No known key found for this signature in database
GPG Key ID: 0DD294BFDE8C95D4
3 changed files with 6 additions and 5 deletions

View File

@ -20,7 +20,7 @@
"docs:generate": "typedoc --out docs .",
"docs:open": "opn docs/index.html",
"clean": "shx rm -rf _bundles lib",
"clean": "shx rm -rf _bundles lib test_temp",
"build:dev": "npm run clean && run-p build:*:dev",
"build:umd:dev": "webpack",
"build:umd:prod": "webpack -p",

2
src/globals.d.ts vendored
View File

@ -15,7 +15,7 @@ declare interface Schema {
declare namespace Chai {
interface Assertion {
bignumber: Assertion;
// HACK: In order t comply with chai-as-promised we make eventually a PromisedAssertion not an assertion
// HACK: In order to comply with chai-as-promised we make eventually a `PromisedAssertion` not an `Assertion`
eventually: PromisedAssertion;
}
}

View File

@ -1,15 +1,16 @@
/**
* This is to generate the umd bundle only
*/
const lodash = require('lodash');
const webpack = require('webpack');
const path = require('path');
const PROD = process.env.NODE_ENV === 'production';
const production = process.env.NODE_ENV === 'production';
let entry = {
'0x': './src/0x.js.ts',
};
if (PROD) {
entry = Object.assign({}, entry, {'0x.min': './src/0x.js.ts'});
if (production) {
entry = _.assign({}, entry, {'0x.min': './src/0x.js.ts'});
}
module.exports = {