crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace lodash with built-ins where possible to reduce bundle size (#1766)

Browse Source 
* add tslint rule to disallow lodash.isUndefined

* add tslint rule to disallow lodash.isNull

* apply fixes
This commit is contained in:
Xianny
2019-04-10 09:36:32 -07:00
committed by GitHub
parent 49d951b7be
commit 7423028fea
299 changed files with 1249 additions and 1038 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/website/ts/pages/instant/config_generator.tsx
View File

@@ -90,8 +90,8 @@ export class ConfigGenerator extends React.Component<ConfigGeneratorProps, Confi
value={value.affiliateInfo.feePercentage}
onChange={this._handleAffiliatePercentageChange}
isDisabled={
_.isUndefined(value.affiliateInfo) ||
_.isUndefined(value.affiliateInfo.feeRecipient) ||
value.affiliateInfo === undefined ||
value.affiliateInfo.feeRecipient === undefined ||
_.isEmpty(value.affiliateInfo.feeRecipient)
}
/>
@@ -105,7 +105,7 @@ export class ConfigGenerator extends React.Component<ConfigGeneratorProps, Confi
title: 'What tokens can users buy?',
};
}
if (_.isUndefined(this.props.value.availableAssetDatas)) {
if (this.props.value.availableAssetDatas === undefined) {
return {
title: 'What tokens can users buy?',
actionText: 'Unselect All',
@@ -177,7 +177,7 @@ export class ConfigGenerator extends React.Component<ConfigGeneratorProps, Confi
let newAvailableAssetDatas: string[] = [];
const allKnownAssetDatas = _.keys(this.state.availableTokens);
const availableAssetDatas = value.availableAssetDatas;
if (_.isUndefined(availableAssetDatas)) {
if (availableAssetDatas === undefined) {
// It being undefined means it's all tokens.
newAvailableAssetDatas = _.pull(allKnownAssetDatas, assetData);
} else if (!_.includes(availableAssetDatas, assetData)) {
@@ -199,7 +199,7 @@ export class ConfigGenerator extends React.Component<ConfigGeneratorProps, Confi
};
private readonly _setAvailableAssetsFromOrderProvider = async (): Promise<void> => {
const { value } = this.props;
if (!_.isUndefined(value.orderSource) && _.isString(value.orderSource)) {
if (value.orderSource !== undefined && _.isString(value.orderSource)) {
this.setState({ isLoadingAvailableTokens: true });
const networkId = constants.NETWORK_ID_MAINNET;
const sraOrderProvider = new StandardRelayerAPIOrderProvider(value.orderSource, networkId);

4
packages/website/ts/pages/instant/configurator.tsx
View File

@@ -65,14 +65,14 @@ export class Configurator extends React.Component {
<script>
zeroExInstant.render({
orderSource: '${instantConfig.orderSource}',${
!_.isUndefined(instantConfig.affiliateInfo) && instantConfig.affiliateInfo.feeRecipient
instantConfig.affiliateInfo !== undefined && instantConfig.affiliateInfo.feeRecipient
? `\n affiliateInfo: {
feeRecipient: '${instantConfig.affiliateInfo.feeRecipient.toLowerCase()}',
feePercentage: ${instantConfig.affiliateInfo.feePercentage}
},`
: ''
}${
!_.isUndefined(instantConfig.availableAssetDatas)
instantConfig.availableAssetDatas !== undefined
? `\n availableAssetDatas: ${this._renderAvailableAssetDatasString(
instantConfig.availableAssetDatas,
)}`