crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace lodash with built-ins where possible to reduce bundle size (#1766)

Browse Source 
* add tslint rule to disallow lodash.isUndefined

* add tslint rule to disallow lodash.isNull

* apply fixes
This commit is contained in:
Xianny
2019-04-10 09:36:32 -07:00
committed by GitHub
parent 49d951b7be
commit 7423028fea
299 changed files with 1249 additions and 1038 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/sol-trace/package.json
View File

@@ -11,6 +11,7 @@
"build": "tsc -b",
"build:ci": "yarn build",
"lint": "tslint --format stylish --project .",
"fix": "tslint --fix --format stylish --project .",
"clean": "shx rm -rf lib src/artifacts generated_docs",
"docs:json": "typedoc --excludePrivate --excludeExternals --target ES5 --tsconfig typedoc-tsconfig.json --json $JSON_FILE_PATH $PROJECT_FILES"
},

8
packages/sol-trace/src/revert_trace_subprovider.ts
View File

@@ -60,7 +60,7 @@ export class RevertTraceSubprovider extends TraceCollectionSubprovider {
}
private async _printStackTraceAsync(evmCallStack: EvmCallStack): Promise<void> {
const sourceSnippets: SourceSnippet[] = [];
if (_.isUndefined(this._contractsData)) {
if (this._contractsData === undefined) {
this._contractsData = await this._artifactAdapter.collectContractsDataAsync();
}
for (const evmCallStackEntry of evmCallStack) {
@@ -71,7 +71,7 @@ export class RevertTraceSubprovider extends TraceCollectionSubprovider {
}
const bytecode = await this._web3Wrapper.getContractCodeAsync(evmCallStackEntry.address);
const contractData = utils.getContractDataIfExists(this._contractsData, bytecode);
if (_.isUndefined(contractData)) {
if (contractData === undefined) {
const shortenHex = (hex: string) => {
/**
* Length choosen so that both error messages are of the same length
@@ -106,11 +106,11 @@ export class RevertTraceSubprovider extends TraceCollectionSubprovider {
// actually happens in assembly). In that case, we want to keep
// searching backwards by decrementing the pc until we find a
// mapped source range.
while (_.isUndefined(sourceRange) && pc > 0) {
while (sourceRange === undefined && pc > 0) {
sourceRange = pcToSourceRange[pc];
pc -= 1;
}
if (_.isUndefined(sourceRange)) {
if (sourceRange === undefined) {
this._logger.warn(
`could not find matching sourceRange for structLog: ${JSON.stringify(
_.omit(evmCallStackEntry.structLog, 'stack'),