Replace lodash with built-ins where possible to reduce bundle size (#1766)

* add tslint rule to disallow lodash.isUndefined

* add tslint rule to disallow lodash.isNull

* apply fixes

contracts/test-utils/package.json

@@ -17,6 +17,7 @@
         "run_mocha": "mocha --require source-map-support/register --require make-promises-safe 'lib/test/**/*.js' --timeout 100000 --bail --exit",
         "clean": "shx rm -rf lib",
         "lint": "tslint --format stylish --project tsconfig.lint.json",
+        "fix": "tslint --fix --format stylish --project tsconfig.lint.json",
         "coverage:report:text": "istanbul report text",
         "coverage:report:html": "istanbul report html && open coverage/index.html",
         "profiler:report:html": "istanbul report html && open coverage/index.html",

contracts/test-utils/src/assertions.ts

@@ -24,7 +24,7 @@ export type sendTransactionResult = Promise<TransactionReceipt | TransactionRece
  * node.
  */
 async function _getGanacheOrGethErrorAsync(ganacheError: string, gethError: string): Promise<string> {
-    if (_.isUndefined(nodeType)) {
+    if (nodeType === undefined) {
         nodeType = await web3Wrapper.getNodeTypeAsync();
     }
     switch (nodeType) {
@@ -99,7 +99,7 @@ export async function expectTransactionFailedAsync(p: sendTransactionResult, rea
         _.noop(e);
     });
 
-    if (_.isUndefined(nodeType)) {
+    if (nodeType === undefined) {
         nodeType = await web3Wrapper.getNodeTypeAsync();
     }
     switch (nodeType) {

contracts/test-utils/src/block_timestamp.ts

@@ -1,5 +1,3 @@
-import * as _ from 'lodash';
-
 import { constants } from './constants';
 import { web3Wrapper } from './web3_wrapper';
 
@@ -13,7 +11,7 @@ let firstAccount: string | undefined;
  * reject if the time could not be increased.
  */
 export async function increaseTimeAndMineBlockAsync(seconds: number): Promise<number> {
-    if (_.isUndefined(firstAccount)) {
+    if (firstAccount === undefined) {
         const accounts = await web3Wrapper.getAvailableAddressesAsync();
         firstAccount = accounts[0];
     }
@@ -36,7 +34,7 @@ export async function increaseTimeAndMineBlockAsync(seconds: number): Promise<nu
  */
 export async function getLatestBlockTimestampAsync(): Promise<number> {
     const currentBlockIfExists = await web3Wrapper.getBlockIfExistsAsync('latest');
-    if (_.isUndefined(currentBlockIfExists)) {
+    if (currentBlockIfExists === undefined) {
         throw new Error(`Unable to fetch latest block.`);
     }
     return currentBlockIfExists.timestamp;

contracts/test-utils/src/coverage.ts

@@ -1,12 +1,10 @@
 import { devConstants } from '@0x/dev-utils';
 import { CoverageSubprovider, SolCompilerArtifactAdapter } from '@0x/sol-coverage';
-import * as _ from 'lodash';
-
 let coverageSubprovider: CoverageSubprovider;
 
 export const coverage = {
     getCoverageSubproviderSingleton(): CoverageSubprovider {
-        if (_.isUndefined(coverageSubprovider)) {
+        if (coverageSubprovider === undefined) {
             coverageSubprovider = coverage._getCoverageSubprovider();
         }
         return coverageSubprovider;

contracts/test-utils/src/log_decoder.ts

@@ -37,7 +37,7 @@ export class LogDecoder {
     public decodeLogOrThrow<ArgsType extends DecodedLogArgs>(log: LogEntry): LogWithDecodedArgs<ArgsType> | RawLog {
         const logWithDecodedArgsOrLog = this._abiDecoder.tryToDecodeLogOrNoop(log);
         // tslint:disable-next-line:no-unnecessary-type-assertion
-        if (_.isUndefined((logWithDecodedArgsOrLog as LogWithDecodedArgs<ArgsType>).args)) {
+        if ((logWithDecodedArgsOrLog as LogWithDecodedArgs<ArgsType>).args === undefined) {
             throw new Error(`Unable to decode log: ${JSON.stringify(log)}`);
         }
         LogDecoder.wrapLogBigNumbers(logWithDecodedArgsOrLog);

contracts/test-utils/src/profiler.ts

@@ -1,6 +1,5 @@
 import { devConstants } from '@0x/dev-utils';
 import { ProfilerSubprovider, SolCompilerArtifactAdapter } from '@0x/sol-profiler';
-import * as _ from 'lodash';
 
 let profilerSubprovider: ProfilerSubprovider;
 
@@ -12,7 +11,7 @@ export const profiler = {
         profiler.getProfilerSubproviderSingleton().stop();
     },
     getProfilerSubproviderSingleton(): ProfilerSubprovider {
-        if (_.isUndefined(profilerSubprovider)) {
+        if (profilerSubprovider === undefined) {
             profilerSubprovider = profiler._getProfilerSubprovider();
         }
         return profilerSubprovider;

contracts/test-utils/src/revert_trace.ts

@@ -1,12 +1,11 @@
 import { devConstants } from '@0x/dev-utils';
 import { RevertTraceSubprovider, SolCompilerArtifactAdapter } from '@0x/sol-trace';
-import * as _ from 'lodash';
 
 let revertTraceSubprovider: RevertTraceSubprovider;
 
 export const revertTrace = {
     getRevertTraceSubproviderSingleton(): RevertTraceSubprovider {
-        if (_.isUndefined(revertTraceSubprovider)) {
+        if (revertTraceSubprovider === undefined) {
             revertTraceSubprovider = revertTrace._getRevertTraceSubprovider();
         }
         return revertTraceSubprovider;