crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added a test that fails for the old DevUtils

Browse Source
This commit is contained in:
Alex Towle 2020-01-23 15:38:40 -08:00
parent f53606007d
commit 6e5c788e13
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
contracts/integrations/test/dev-utils/order_validation_utils.ts
View File

@ -434,6 +434,25 @@ blockchainTests.resets('OrderValidationUtils/OrderTransferSimulatorUtils', env =
expect(fillableTakerAssetAmount).to.bignumber.equal(signedOrder.takerAssetAmount);
expect(isValidSignature).to.equal(true);
});
it('should not revert when rounding errors occur', async () => {
signedOrder = await maker.signOrderAsync({
makerAssetAmount: new BigNumber('2040250070'),
takerAssetAmount: new BigNumber('2040250070000000000000'),
makerFee: new BigNumber(0),
takerFee: new BigNumber(0),
});
await erc20Token.setBalance(maker.address, signedOrder.makerAssetAmount).awaitTransactionSuccessAsync();
await erc20Token.approve(erc20Proxy.address, signedOrder.makerAssetAmount).awaitTransactionSuccessAsync({
from: maker.address,
});
await erc20Token2.setBalance(taker.address, signedOrder.takerAssetAmount).awaitTransactionSuccessAsync();
await erc20Token2.approve(erc20Proxy.address, signedOrder.takerAssetAmount).awaitTransactionSuccessAsync({
from: taker.address,
});
await taker.configureERC20TokenAsync(deployment.tokens.weth, deployment.staking.stakingProxy.address);
await taker.fillOrderAsync(signedOrder, new BigNumber('2040250069999999999990'));
await devUtils.getOrderRelevantState(signedOrder, signedOrder.signature).callAsync();
});
});
describe('getOrderRelevantStates', async () => {
it('should return the correct information for multiple orders', async () => {