crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use != instead of < in loops

Browse Source
This commit is contained in:
Amir Bandeali 2019-03-04 17:00:57 -08:00
parent 350474540b
commit 6cfc9ba47b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contracts/coordinator/contracts/src/MixinCoordinatorApprovalVerifier.sol
View File

@ -105,7 +105,7 @@ contract MixinCoordinatorApprovalVerifier is
address[] memory approvalSignerAddresses = new address[](0); address[] memory approvalSignerAddresses = new address[](0);
uint256 signaturesLength = approvalSignatures.length; uint256 signaturesLength = approvalSignatures.length;
for (uint256 i = 0; i < signaturesLength; i++) { for (uint256 i = 0; i != signaturesLength; i++) {
// Create approval message // Create approval message
uint256 currentApprovalExpirationTimeSeconds = approvalExpirationTimeSeconds[i]; uint256 currentApprovalExpirationTimeSeconds = approvalExpirationTimeSeconds[i];
CoordinatorApproval memory approval = CoordinatorApproval({ CoordinatorApproval memory approval = CoordinatorApproval({
@ -134,7 +134,7 @@ contract MixinCoordinatorApprovalVerifier is
approvalSignerAddresses = approvalSignerAddresses.append(tx.origin); approvalSignerAddresses = approvalSignerAddresses.append(tx.origin);
uint256 ordersLength = orders.length; uint256 ordersLength = orders.length;
for (uint256 i = 0; i < ordersLength; i++) { for (uint256 i = 0; i != ordersLength; i++) {
// Do not check approval if the order's senderAddress is null // Do not check approval if the order's senderAddress is null
if (orders[i].senderAddress == address(0)) { if (orders[i].senderAddress == address(0)) {
continue; continue;