Add Todos

This commit is contained in:
Remco Bloemen
2018-02-23 15:58:50 -08:00
committed by Amir Bandeali
parent 012ee310a4
commit 55da59a537
2 changed files with 3 additions and 0 deletions

View File

@@ -98,6 +98,7 @@ contract MixinExchangeCore is
});
// Validate order and maker only if first time seen
// TODO: Read filled and cancelled only once
if (filled[order.orderHash] == 0 && cancelled[order.orderHash] == 0) {
require(order.makerTokenAmount > 0);
require(order.takerTokenAmount > 0);

View File

@@ -64,6 +64,8 @@ contract MixinWrapperFunctions is
bytes4 FILL_ORDER_FUNCTION_SIGNATURE = bytes4(keccak256("fillOrder(address[5],uint256[6],uint256,uint8,bytes32,bytes32)"));
// Input size is padded to a 4 + n * 32 byte boundary
// TODO: Construct the input array using readable Solidity instead
// of assembly.
uint256 mask = 0x1F;
uint256 inputSize = 388 + (signature.length + mask) & ~mask;