crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/contracts-exchange-libs: Correct internal variable naming in src/index.ts.

Browse Source 
`@0x/contracts-utils`: Correct internal variable naming in `src/index.ts`.
`@0x/contracts-exchange`: Remove functions from `TestExchangeInternals.sol` that are now in other packages.
`@0x/contracts-exchange`: Remove `TestExchangeMath.sol`. Exchange math functions are now tested in `@0x/contracts-exchange-libs`.
`@0x/contracts-exchange`: Move `ReferenceFunctions` to default package export.
`@0x/contracts-exchange`: Update `match_order.ts` tests to use reference math functions instead of `TestExchangeMath`.
`@0x/contracts-exchange`: Remove `_updateFilledState()` combinatorial tests in favor of normal unit testing. Combinatorial testing was overkill.
`@0x/contracts-exchange`: Update/refactor `calculateFillResults()` combinatorial tests to use the reference functions and hide them behind `TEST_ALL`.
This commit is contained in:
Lawrence Forman
2019-08-01 18:17:46 -04:00
parent 264b1d69d9
commit 51391b7f0e
16 changed files with 193 additions and 663 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
contracts/exchange-libs/test/lib_fill_results.ts
View File

@@ -24,8 +24,9 @@ blockchainTests('LibFillResults', env => {
describe('addFillResults', () => {
function makeFillResults(value: BigNumber): FillResults {
// We reuse values across fields, but this is fine because
// `addFillResults()` never does any math between them.
// HACK(dorothy-zbornak): We reuse values across fields,
// but this is fine because `addFillResults()` never does
// any math between them.
return {
makerAssetFilledAmount: value,
takerAssetFilledAmount: value,
@@ -54,6 +55,8 @@ blockchainTests('LibFillResults', env => {
);
}
// TODO(dorothy-zbornak): Do we really need these?
// Just a couple edge cases would likely suffice.
describe.optional('combinatorial tests', () => {
testCombinatoriallyWithReferenceFunc(
'addFillResults',