crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Decide to throw for Caller signature type for now

Browse Source
This commit is contained in:
Fabio Berger 2018-05-30 17:54:59 -07:00
parent 9200ed2216
commit 4eb58a70bb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/order-utils/src/signature_utils.ts
View File

@ -34,9 +34,10 @@ export async function isValidSignatureAsync(
case SignatureType.Invalid: case SignatureType.Invalid:
return false; return false;
// Question: Does it make sense to handle this?
case SignatureType.Caller: case SignatureType.Caller:
return true; // HACK: We currently do not "validate" the caller signature type.
// It can only be validated during Exchange contract execution.
throw new Error('Caller signature type cannot be validated off-chain');
// TODO: Rename this type to `EthSign` b/c multiple of the signature // TODO: Rename this type to `EthSign` b/c multiple of the signature
// types use ECRecover... // types use ECRecover...