crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove getZeroExProvider method since it can be confusing

Browse Source
This commit is contained in:
Fabio Berger 2019-02-21 16:07:23 -08:00
parent 5814cd5fae
commit 3f9872d8b3
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contracts/exchange/test/utils/fill_order_combinatorial_utils.ts
View File

@ -26,7 +26,7 @@ import {
OrderValidationUtils, OrderValidationUtils,
} from '@0x/order-utils'; } from '@0x/order-utils';
import { AssetProxyId, RevertReason, SignatureType, SignedOrder } from '@0x/types'; import { AssetProxyId, RevertReason, SignatureType, SignedOrder } from '@0x/types';
import { BigNumber, errorUtils, logUtils } from '@0x/utils'; import { BigNumber, errorUtils, logUtils, providerUtils } from '@0x/utils';
import { Web3Wrapper } from '@0x/web3-wrapper'; import { Web3Wrapper } from '@0x/web3-wrapper';
import * as chai from 'chai'; import * as chai from 'chai';
import { LogWithDecodedArgs, TxData } from 'ethereum-types'; import { LogWithDecodedArgs, TxData } from 'ethereum-types';
@ -60,7 +60,8 @@ export async function fillOrderCombinatorialUtilsFactoryAsync(
const [ownerAddress, makerAddress, takerAddress] = userAddresses; const [ownerAddress, makerAddress, takerAddress] = userAddresses;
const makerPrivateKey = constants.TESTRPC_PRIVATE_KEYS[userAddresses.indexOf(makerAddress)]; const makerPrivateKey = constants.TESTRPC_PRIVATE_KEYS[userAddresses.indexOf(makerAddress)];
const provider = web3Wrapper.getZeroExProvider(); const supportedProvider = web3Wrapper.getProvider();
const provider = providerUtils.standardizeOrThrow(supportedProvider);
const erc20Wrapper = new ERC20Wrapper(provider, userAddresses, ownerAddress); const erc20Wrapper = new ERC20Wrapper(provider, userAddresses, ownerAddress);
const erc721Wrapper = new ERC721Wrapper(provider, userAddresses, ownerAddress); const erc721Wrapper = new ERC721Wrapper(provider, userAddresses, ownerAddress);

7
packages/web3-wrapper/src/web3_wrapper.ts
View File

@ -171,13 +171,6 @@ export class Web3Wrapper {
public getProvider(): SupportedProvider { public getProvider(): SupportedProvider {
return this._supportedProvider; return this._supportedProvider;
} }
/**
* Retrieve the Web3 provider
* @return Web3 provider instance
*/
public getZeroExProvider(): ZeroExProvider {
return this._provider;
}
/** /**
* Update the used Web3 provider * Update the used Web3 provider
* @param provider The new Web3 provider to be set * @param provider The new Web3 provider to be set