Fixed review comments

2019-07-30 12:04:03 -07:00
parent 8cf4fb9adc
commit 3ca3a2820d
10 changed files with 76 additions and 27 deletions
--- a/contracts/utils/test/lib_rich_errors.ts
+++ b/contracts/utils/test/lib_rich_errors.ts
@@ -1,5 +1,6 @@
 import { chaiSetup, constants, provider, txDefaults, web3Wrapper } from '@0x/contracts-test-utils';
 import { BlockchainLifecycle } from '@0x/dev-utils';
+import { StringRevertError } from '@0x/utils';
 import * as chai from 'chai';
 import * as _ from 'lodash';

@@ -30,5 +31,10 @@ describe('LibEIP712', () => {
        it('should correctly revert the extra bytes', async () => {
            return expect(lib.externalRRevert.callAsync(constants.NULL_BYTES)).to.revertWith(constants.NULL_BYTES);
        });
+
+        it('should correctly revert a StringRevertError', async () => {
+            const error = new StringRevertError('foo');
+            return expect(lib.externalRRevert.callAsync(error.encode())).to.revertWith(error);
+        });
    });
 });