Addressed final review comments
This commit is contained in:
@@ -8,7 +8,7 @@ library LibOwnableRichErrors {
|
|||||||
0x1de45ad1;
|
0x1de45ad1;
|
||||||
|
|
||||||
// bytes4(keccak256("TransferOwnerToZeroError()"))
|
// bytes4(keccak256("TransferOwnerToZeroError()"))
|
||||||
bytes internal constant TRANSFER_OWNER_TO_ZERO_ERROR_SELECTOR =
|
bytes internal constant TRANSFER_OWNER_TO_ZERO_ERROR_BYTES =
|
||||||
hex"e69edc3e";
|
hex"e69edc3e";
|
||||||
|
|
||||||
// solhint-disable func-name-mixedcase
|
// solhint-disable func-name-mixedcase
|
||||||
@@ -32,6 +32,6 @@ library LibOwnableRichErrors {
|
|||||||
pure
|
pure
|
||||||
returns (bytes memory)
|
returns (bytes memory)
|
||||||
{
|
{
|
||||||
return TRANSFER_OWNER_TO_ZERO_ERROR_SELECTOR;
|
return TRANSFER_OWNER_TO_ZERO_ERROR_BYTES;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -50,11 +50,7 @@ describe('Authorizable', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('should allow owner to add an authorized address', async () => {
|
it('should allow owner to add an authorized address', async () => {
|
||||||
await authorizable.addAuthorizedAddress.awaitTransactionSuccessAsync(
|
await authorizable.addAuthorizedAddress.awaitTransactionSuccessAsync(address, { from: owner });
|
||||||
address,
|
|
||||||
{ from: owner },
|
|
||||||
constants.AWAIT_TRANSACTION_MINED_MS,
|
|
||||||
);
|
|
||||||
const isAuthorized = await authorizable.authorized.callAsync(address);
|
const isAuthorized = await authorizable.authorized.callAsync(address);
|
||||||
expect(isAuthorized).to.be.true();
|
expect(isAuthorized).to.be.true();
|
||||||
});
|
});
|
||||||
|
Reference in New Issue
Block a user