crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Getting rid of unused function, and using track prefix

Browse Source
This commit is contained in:
Steve Klebanoff 2018-11-16 15:06:11 -08:00
parent 21ae0c46e1
commit 31ffa65f59
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/instant/src/components/zero_ex_instant_provider.tsx
View File

@ -132,7 +132,7 @@ export class ZeroExInstantProvider extends React.Component<ZeroExInstantProvider
gitSha: process.env.GIT_SHA, gitSha: process.env.GIT_SHA,
npmVersion: process.env.NPM_PACKAGE_VERSION, npmVersion: process.env.NPM_PACKAGE_VERSION,
}); });
analytics.widgetOpened(); analytics.trackWidgetOpened();
} }
public componentWillUnmount(): void { public componentWillUnmount(): void {
if (this._accountUpdateHeartbeat) { if (this._accountUpdateHeartbeat) {

2
packages/instant/src/redux/analytics_middleware.ts
View File

@ -24,7 +24,7 @@ export const analyticsMiddleware: Middleware = store => next => middlewareAction
if (curAccount.state === AccountState.Ready && prevAccount.state !== AccountState.Ready) { if (curAccount.state === AccountState.Ready && prevAccount.state !== AccountState.Ready) {
const ethAddress = curAccount.address; const ethAddress = curAccount.address;
analytics.addUserProperties({ ethAddress }); analytics.addUserProperties({ ethAddress });
analytics.walletReady(); analytics.trackWalletReady();
} }
break; break;
case ActionTypes.UPDATE_ACCOUNT_ETH_BALANCE: case ActionTypes.UPDATE_ACCOUNT_ETH_BALANCE:

6
packages/instant/src/util/analytics.ts
View File

@ -3,7 +3,6 @@ import { ObjectMap } from '@0x/types';
import { heapUtil } from './heap'; import { heapUtil } from './heap';
enum EventNames { enum EventNames {
WALLET_OPENED = 'Wallet - Opened',
WALLET_READY = 'Wallet - Ready', WALLET_READY = 'Wallet - Ready',
WIDGET_OPENED = 'Widget - Opened', WIDGET_OPENED = 'Widget - Opened',
} }
@ -43,7 +42,6 @@ export const analytics = {
addEventProperties: (properties: AnalyticsEventOptions): void => { addEventProperties: (properties: AnalyticsEventOptions): void => {
heapUtil.evaluateHeapCall(heap => heap.addEventProperties(properties)); heapUtil.evaluateHeapCall(heap => heap.addEventProperties(properties));
}, },
walletOpened: trackingEventFnWithoutPayload(EventNames.WALLET_OPENED), trackWalletReady: trackingEventFnWithoutPayload(EventNames.WALLET_READY),
walletReady: trackingEventFnWithoutPayload(EventNames.WALLET_READY), trackWidgetOpened: trackingEventFnWithoutPayload(EventNames.WIDGET_OPENED),
widgetOpened: trackingEventFnWithoutPayload(EventNames.WIDGET_OPENED),
}; };