crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address feedback

Browse Source
This commit is contained in:
Leonid Logvinov 2017-05-26 12:17:31 +02:00
parent 183e8a7138
commit 3195741ebc
No known key found for this signature in database
GPG Key ID: 0DD294BFDE8C95D4
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ts/0x.js.ts
View File

@ -132,8 +132,9 @@ export class ZeroEx {
/** /**
* Converts BigNumber instance to BN * Converts BigNumber instance to BN
* We do it because ethABI accepts only BN's * The only we convert to BN is to remain compatible with `ethABI. soliditySHA3 ` that
* We should be consistent about using BigNumbers in our codebase and not use BN anywhere else * expects values of Solidity type `uint` to be of type `BN`.
* We do not use BN anywhere else in the codebase.
*/ */
private static bigNumberToBN(value: BigNumber.BigNumber) { private static bigNumberToBN(value: BigNumber.BigNumber) {
return new BN(value.toString(), 10); return new BN(value.toString(), 10);

2
src/ts/globals.d.ts vendored
View File

@ -26,5 +26,5 @@ declare module 'ethereumjs-util' {
} }
declare module 'ethereumjs-abi' { declare module 'ethereumjs-abi' {
const soliditySHA3: (argTypes: string[], args: any) => Buffer; const soliditySHA3: (argTypes: string[], args: any[]) => Buffer;
} }

3
src/ts/types.ts
View File

@ -13,8 +13,5 @@ function strEnum(values: string[]): {[key: string]: string} {
export const SolidityTypes = strEnum([ export const SolidityTypes = strEnum([
'address', 'address',
'uint256', 'uint256',
'uint8',
'string',
'bool',
]); ]);
export type SolidityTypes = keyof typeof SolidityTypes; export type SolidityTypes = keyof typeof SolidityTypes;