crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add tests

Browse Source
This commit is contained in:
Brandon Millman 2018-08-01 15:08:34 -07:00
parent 7c864b81e0
commit 30c6fe08ec
2 changed files with 85 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
packages/contract-wrappers/src/utils/market_orders_optimization_utils.ts
View File

@ -11,15 +11,12 @@ export const marketOrdersOptimizationUtils = {
* @returns optimized orders * @returns optimized orders
*/ */
optimizeMarketOrders(orders: SignedOrder[]): SignedOrder[] { optimizeMarketOrders(orders: SignedOrder[]): SignedOrder[] {
const optimizedOrders = _.map(orders, (order, index) => { const optimizedOrders = _.map(orders, (order, index) =>
const makerAssetData = index === 0 ? order.makerAssetData : constants.NULL_BYTES; transformOrder(order, {
const takerAssetData = constants.NULL_BYTES; makerAssetData: index === 0 ? order.makerAssetData : constants.NULL_BYTES,
return { takerAssetData: constants.NULL_BYTES,
...order, }),
makerAssetData, );
takerAssetData,
};
});
return optimizedOrders; return optimizedOrders;
}, },
/** /**
@ -29,15 +26,19 @@ export const marketOrdersOptimizationUtils = {
* @returns optimized orders * @returns optimized orders
*/ */
optimizeFeeOrders(orders: SignedOrder[]): SignedOrder[] { optimizeFeeOrders(orders: SignedOrder[]): SignedOrder[] {
const optimizedOrders = _.map(orders, order => { const optimizedOrders = _.map(orders, (order, index) =>
const makerAssetData = constants.NULL_BYTES; transformOrder(order, {
const takerAssetData = constants.NULL_BYTES; makerAssetData: constants.NULL_BYTES,
return { takerAssetData: constants.NULL_BYTES,
...order, }),
makerAssetData, );
takerAssetData,
};
});
return optimizedOrders; return optimizedOrders;
}, },
}; };
const transformOrder = (order: SignedOrder, partialOrder: Partial<SignedOrder>) => {
return {
...order,
...partialOrder,
};
};

66
packages/contract-wrappers/test/market_orders_optimization_utils_test.ts Normal file
View File

@ -0,0 +1,66 @@
import { orderFactory } from '@0xproject/order-utils';
import * as chai from 'chai';
import * as _ from 'lodash';
import 'mocha';
import { constants } from '../src/utils/constants';
import { marketOrdersOptimizationUtils } from '../src/utils/market_orders_optimization_utils';
import { chaiSetup } from './utils/chai_setup';
import { assert } from '../src/utils/assert';
import { NULL_BYTES } from '@0xproject/utils';
chaiSetup.configure();
const expect = chai.expect;
// utility for generating a set of order objects with mostly NULL values
// except for a specified makerAssetData and takerAssetData
const FAKE_ORDERS_COUNT = 5;
const generateFakeOrders = (makerAssetData: string, takerAssetData: string) =>
_.map(_.range(FAKE_ORDERS_COUNT), index => {
const order = orderFactory.createOrder(
constants.NULL_ADDRESS,
constants.NULL_ADDRESS,
constants.NULL_ADDRESS,
constants.ZERO_AMOUNT,
constants.ZERO_AMOUNT,
constants.ZERO_AMOUNT,
makerAssetData,
constants.ZERO_AMOUNT,
takerAssetData,
constants.NULL_ADDRESS,
constants.NULL_ADDRESS,
);
return {
...order,
signature: 'dummy signature',
};
});
describe('marketOrdersOptimizationUtils', () => {
const fakeMakerAssetData = 'fakeMakerAssetData';
const fakeTakerAssetData = 'fakeTakerAssetData';
const orders = generateFakeOrders(fakeMakerAssetData, fakeTakerAssetData);
describe('#optimizeMarketOrders', () => {
it('should make makerAssetData `0x` unless first order', () => {
const optimizedOrders = marketOrdersOptimizationUtils.optimizeMarketOrders(orders);
expect(optimizedOrders[0].makerAssetData).to.equal(fakeMakerAssetData);
const ordersWithoutHead = _.slice(optimizedOrders, 1);
_.forEach(ordersWithoutHead, order => expect(order.makerAssetData).to.equal(constants.NULL_BYTES));
});
it('should make all takerAssetData `0x`', () => {
const optimizedOrders = marketOrdersOptimizationUtils.optimizeMarketOrders(orders);
_.forEach(optimizedOrders, order => expect(order.takerAssetData).to.equal(constants.NULL_BYTES));
});
});
describe('#optimizeFeeOrders', () => {
it('should make all makerAssetData `0x`', () => {
const optimizedOrders = marketOrdersOptimizationUtils.optimizeFeeOrders(orders);
_.forEach(optimizedOrders, order => expect(order.makerAssetData).to.equal(constants.NULL_BYTES));
});
it('should make all takerAssetData `0x`', () => {
const optimizedOrders = marketOrdersOptimizationUtils.optimizeFeeOrders(orders);
_.forEach(optimizedOrders, order => expect(order.takerAssetData).to.equal(constants.NULL_BYTES));
});
});
});