@0x/contracts-exchange: Fix matchOrders() not paying fees if same feeRecipient but different feeAssetDatas.

2019-05-16 02:18:07 -04:00
parent 79b8f85cdf
commit 26317d16ff
1 changed files with 15 additions and 15 deletions
--- a/contracts/exchange/contracts/src/MixinMatchOrders.sol
+++ b/contracts/exchange/contracts/src/MixinMatchOrders.sol
@@ -342,22 +342,22 @@ contract MixinMatchOrders is
                        matchedFillResults.right.takerFeePaid
                        )
                    );
+                return;
            }
-        } else {
-            _dispatchTransferFrom(
-                leftOrderHash,
-                leftTakerFeeAssetData,
-                takerAddress,
-                leftFeeRecipientAddress,
-                matchedFillResults.left.takerFeePaid
-            );
-            _dispatchTransferFrom(
-                rightOrderHash,
-                rightTakerFeeAssetData,
-                takerAddress,
-                rightFeeRecipientAddress,
-                matchedFillResults.right.takerFeePaid
-            );
        }
+        _dispatchTransferFrom(
+            leftOrderHash,
+            leftTakerFeeAssetData,
+            takerAddress,
+            leftFeeRecipientAddress,
+            matchedFillResults.left.takerFeePaid
+        );
+        _dispatchTransferFrom(
+            rightOrderHash,
+            rightTakerFeeAssetData,
+            takerAddress,
+            rightFeeRecipientAddress,
+            matchedFillResults.right.takerFeePaid
+        );
    }
 }