don't use uppercase for constant variable unless it's global to the entire file

This commit is contained in:
Fabio Berger 2017-05-29 13:34:49 +02:00
parent 4a3a20ef43
commit 232e031959

View File

@ -12,7 +12,7 @@ const expect = chai.expect;
describe('ZeroEx library', () => {
describe('#getOrderHash', () => {
const ORDER_HASH = '0x103a5e97dab5dbeb8f385636f86a7d1e458a7ccbe1bd194727f0b2f85ab116c7';
const expectedOrderHash = '0x103a5e97dab5dbeb8f385636f86a7d1e458a7ccbe1bd194727f0b2f85ab116c7';
it('defaults takerAddress to NULL address', () => {
const orderHash = ZeroEx.getOrderHashHex(
constants.NULL_ADDRESS,
@ -28,7 +28,7 @@ describe('ZeroEx library', () => {
new BigNumber(0),
new BigNumber(0),
);
expect(orderHash).to.be.equal(ORDER_HASH);
expect(orderHash).to.be.equal(expectedOrderHash);
});
it('calculates the order hash', () => {
const orderHash = ZeroEx.getOrderHashHex(
@ -45,7 +45,7 @@ describe('ZeroEx library', () => {
new BigNumber(0),
new BigNumber(0),
);
expect(orderHash).to.be.equal(ORDER_HASH);
expect(orderHash).to.be.equal(expectedOrderHash);
});
});
describe('#isValidSignature', () => {