remove unnecessary assertion and add regression test
This commit is contained in:
@@ -89,7 +89,6 @@ export class TokenWrapper extends ContractWrapper {
|
|||||||
public async getAllowanceAsync(tokenAddress: string, ownerAddress: string, spenderAddress: string) {
|
public async getAllowanceAsync(tokenAddress: string, ownerAddress: string, spenderAddress: string) {
|
||||||
assert.isETHAddressHex('ownerAddress', ownerAddress);
|
assert.isETHAddressHex('ownerAddress', ownerAddress);
|
||||||
assert.isETHAddressHex('tokenAddress', tokenAddress);
|
assert.isETHAddressHex('tokenAddress', tokenAddress);
|
||||||
await assert.isUserAddressAvailableAsync(this._web3Wrapper);
|
|
||||||
|
|
||||||
const tokenContract = await this._getTokenContractAsync(tokenAddress);
|
const tokenContract = await this._getTokenContractAsync(tokenAddress);
|
||||||
let allowanceInBaseUnits = await tokenContract.allowance.call(ownerAddress, spenderAddress);
|
let allowanceInBaseUnits = await tokenContract.allowance.call(ownerAddress, spenderAddress);
|
||||||
|
@@ -176,7 +176,6 @@ describe('TokenWrapper', () => {
|
|||||||
before(async () => {
|
before(async () => {
|
||||||
const hasAddresses = false;
|
const hasAddresses = false;
|
||||||
const web3WithoutAccounts = web3Factory.create(hasAddresses);
|
const web3WithoutAccounts = web3Factory.create(hasAddresses);
|
||||||
web3WithoutAccounts.eth.getAccounts(console.log);
|
|
||||||
zeroExWithoutAccounts = new ZeroEx(web3WithoutAccounts.currentProvider);
|
zeroExWithoutAccounts = new ZeroEx(web3WithoutAccounts.currentProvider);
|
||||||
});
|
});
|
||||||
it('should return balance even when called with Web3 provider instance without addresses', async () => {
|
it('should return balance even when called with Web3 provider instance without addresses', async () => {
|
||||||
@@ -208,6 +207,7 @@ describe('TokenWrapper', () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
describe('#getAllowanceAsync', () => {
|
describe('#getAllowanceAsync', () => {
|
||||||
|
describe('With web3 provider with accounts', () => {
|
||||||
it('should get the proxy allowance', async () => {
|
it('should get the proxy allowance', async () => {
|
||||||
const token = tokens[0];
|
const token = tokens[0];
|
||||||
const ownerAddress = coinbase;
|
const ownerAddress = coinbase;
|
||||||
@@ -229,6 +229,29 @@ describe('TokenWrapper', () => {
|
|||||||
return expect(allowance).to.be.bignumber.equal(expectedAllowance);
|
return expect(allowance).to.be.bignumber.equal(expectedAllowance);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
describe('With web3 provider without accounts', () => {
|
||||||
|
let zeroExWithoutAccounts: ZeroEx;
|
||||||
|
before(async () => {
|
||||||
|
const hasAddresses = false;
|
||||||
|
const web3WithoutAccounts = web3Factory.create(hasAddresses);
|
||||||
|
zeroExWithoutAccounts = new ZeroEx(web3WithoutAccounts.currentProvider);
|
||||||
|
});
|
||||||
|
it('should get the proxy allowance', async () => {
|
||||||
|
const token = tokens[0];
|
||||||
|
const ownerAddress = coinbase;
|
||||||
|
const spenderAddress = addressWithoutFunds;
|
||||||
|
|
||||||
|
const amountInBaseUnits = new BigNumber(50);
|
||||||
|
await zeroEx.token.setAllowanceAsync(token.address, ownerAddress, spenderAddress, amountInBaseUnits);
|
||||||
|
|
||||||
|
const allowance = await zeroExWithoutAccounts.token.getAllowanceAsync(
|
||||||
|
token.address, ownerAddress, spenderAddress,
|
||||||
|
);
|
||||||
|
const expectedAllowance = amountInBaseUnits;
|
||||||
|
return expect(allowance).to.be.bignumber.equal(expectedAllowance);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
describe('#getProxyAllowanceAsync', () => {
|
describe('#getProxyAllowanceAsync', () => {
|
||||||
it('should get the proxy allowance', async () => {
|
it('should get the proxy allowance', async () => {
|
||||||
const token = tokens[0];
|
const token = tokens[0];
|
||||||
|
Reference in New Issue
Block a user