Verify length on EIP712 signatures

2018-02-23 15:13:18 -08:00
parent 69ab913bc6
commit 1e07fcacac
1 changed files with 2 additions and 1 deletions
--- a/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol
+++ b/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol
@@ -96,9 +96,10 @@ contract MixinSignatureValidator is
            );
            isValid = signer == recovered;
            return isValid;
-            
+        
        // Signature using EIP712
        } else if (signatureType == SignatureType.EIP712) {
+            require(signature.length == 66);
            v = uint8(signature[1]);
            r = get32(signature, 2);
            s = get32(signature, 34);