Sanity check on order offset when hashing

2019-09-06 15:28:07 -07:00 · 2019-09-06 15:28:07 -07:00 · 1dc1218bfc
commit 1dc1218bfc
parent f477c0fcc2
1 changed files with 6 additions and 1 deletions
--- a/contracts/exchange-libs/contracts/src/LibOrder.sol
+++ b/contracts/exchange-libs/contracts/src/LibOrder.sol
@ -133,6 +133,11 @@ library LibOrder {
        // ));

        assembly {
+            // Assert order offset (this is an internal error that should never be triggered)
+            if lt(order, 32) {
+                invalid()
+            }
+
            // Calculate memory addresses that will be swapped out before hashing
            let pos1 := sub(order, 32)
            let pos2 := add(order, 320)