crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update comments

Browse Source
This commit is contained in:
Jacob Evans
2019-03-20 15:31:04 +01:00
parent 957f8c56a1
commit 18c613a611
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts
View File

@@ -1141,7 +1141,8 @@ export class ExchangeWrapper extends ContractWrapper {
* Validate if the supplied order is fillable, and throw if it isn't * Validate if the supplied order is fillable, and throw if it isn't
* @param signedOrder SignedOrder of interest * @param signedOrder SignedOrder of interest
* @param opts ValidateOrderFillableOpts options (e.g expectedFillTakerTokenAmount. * @param opts ValidateOrderFillableOpts options (e.g expectedFillTakerTokenAmount.
* If it isn't supplied, we check if the order is fillable for a non-zero amount) * If it isn't supplied, we check if the order is fillable for the remaining amount.
* To check if the order is fillable for any amount set validateRemainingOrderAmountIsFillable to false.)
*/ */
public async validateOrderFillableOrThrowAsync( public async validateOrderFillableOrThrowAsync(
signedOrder: SignedOrder, signedOrder: SignedOrder,

2
packages/contract-wrappers/test/exchange_wrapper_test.ts
View File

@@ -282,7 +282,7 @@ describe('ExchangeWrapper', () => {
expect(ordersInfo[1].orderHash).to.be.equal(anotherOrderHash); expect(ordersInfo[1].orderHash).to.be.equal(anotherOrderHash);
}); });
}); });
describe.only('#validateOrderFillableOrThrowAsync', () => { describe('#validateOrderFillableOrThrowAsync', () => {
it('should throw if signature is invalid', async () => { it('should throw if signature is invalid', async () => {
const signedOrderWithInvalidSignature = { const signedOrderWithInvalidSignature = {
...signedOrder, ...signedOrder,