crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/contracts-exchange-libs: Add complementary tests when rounding up and down behavior with isRoundingErrorFloor() and isRoundingerrorCeil().

Browse Source
This commit is contained in:
Lawrence Forman 2019-08-09 21:07:23 -04:00
parent e3aa76cd09
commit 18485dd456
2 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
contracts/exchange-libs/test/lib_math.ts
View File

@ -299,19 +299,19 @@ blockchainTests('LibMath', env => {
}); });
describe('explicit tests', () => { describe('explicit tests', () => {
it('returns true for a rounding error', async () => { it('returns true when `numerator * target / denominator` produces an error >= 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(102);
const target = new BigNumber(333); const target = new BigNumber(52);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = await libsContract.isRoundingErrorFloor.callAsync(numerator, denominator, target); const actual = await libsContract.isRoundingErrorFloor.callAsync(numerator, denominator, target);
expect(actual).to.eq(true); expect(actual).to.eq(true);
}); });
it('returns false for not a rounding error', async () => { it('returns false when `numerator * target / denominator` produces an error < 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(101);
const target = new BigNumber(5e2); const target = new BigNumber(92);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = await libsContract.isRoundingErrorFloor.callAsync(numerator, denominator, target); const actual = await libsContract.isRoundingErrorFloor.callAsync(numerator, denominator, target);
expect(actual).to.eq(false); expect(actual).to.eq(false);
@ -365,19 +365,19 @@ blockchainTests('LibMath', env => {
}); });
describe('explicit tests', () => { describe('explicit tests', () => {
it('returns true for a rounding error', async () => { it('returns true when `numerator * target / (denominator - 1)` produces an error >= 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(101);
const target = new BigNumber(333); const target = new BigNumber(92);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = await libsContract.isRoundingErrorCeil.callAsync(numerator, denominator, target); const actual = await libsContract.isRoundingErrorCeil.callAsync(numerator, denominator, target);
expect(actual).to.eq(true); expect(actual).to.eq(true);
}); });
it('returns false for not a rounding error', async () => { it('returns false when `numerator * target / (denominator - 1)` produces an error < 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(102);
const target = new BigNumber(5e2); const target = new BigNumber(52);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = await libsContract.isRoundingErrorCeil.callAsync(numerator, denominator, target); const actual = await libsContract.isRoundingErrorCeil.callAsync(numerator, denominator, target);
expect(actual).to.eq(false); expect(actual).to.eq(false);

32
contracts/exchange-libs/test/reference_functions.ts
View File

@ -222,19 +222,19 @@ describe('Reference Functions', () => {
describe('isRoundingErrorFloor', () => { describe('isRoundingErrorFloor', () => {
describe('explicit tests', () => { describe('explicit tests', () => {
it('returns true for a rounding error', () => { it('returns true when `numerator * target / denominator` produces an error >= 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(102);
const target = new BigNumber(333); const target = new BigNumber(52);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = isRoundingErrorFloor(numerator, denominator, target); const actual = isRoundingErrorFloor(numerator, denominator, target);
expect(actual).to.eq(true); expect(actual).to.eq(true);
}); });
it('returns false for not a rounding error', () => { it('returns false when `numerator * target / denominator` produces an error < 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(101);
const target = new BigNumber(5e2); const target = new BigNumber(92);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = isRoundingErrorFloor(numerator, denominator, target); const actual = isRoundingErrorFloor(numerator, denominator, target);
expect(actual).to.eq(false); expect(actual).to.eq(false);
@ -268,19 +268,19 @@ describe('Reference Functions', () => {
describe('isRoundingErrorCeil', () => { describe('isRoundingErrorCeil', () => {
describe('explicit tests', () => { describe('explicit tests', () => {
it('returns true for a rounding error', () => { it('returns true when `numerator * target / (denominator - 1)` produces an error >= 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(101);
const target = new BigNumber(333); const target = new BigNumber(92);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = isRoundingErrorCeil(numerator, denominator, target); const actual = isRoundingErrorCeil(numerator, denominator, target);
expect(actual).to.eq(true); expect(actual).to.eq(true);
}); });
it('returns false for not a rounding error', () => { it('returns false when `numerator * target / (denominator - 1)` produces an error < 0.1%', async () => {
const numerator = new BigNumber(1e3); const numerator = new BigNumber(100);
const denominator = new BigNumber(1e4); const denominator = new BigNumber(102);
const target = new BigNumber(5e2); const target = new BigNumber(52);
// tslint:disable-next-line: boolean-naming // tslint:disable-next-line: boolean-naming
const actual = isRoundingErrorCeil(numerator, denominator, target); const actual = isRoundingErrorCeil(numerator, denominator, target);
expect(actual).to.eq(false); expect(actual).to.eq(false);