crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed redundant status checks in matchOrders. Saves gas, plus follows pattern of fillOrder more closely.

Browse Source
This commit is contained in:
Greg Hysen
2018-05-14 14:19:53 -07:00
parent 3e6e7fb272
commit 061facdcce
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/contracts/src/contracts/current/protocol/Exchange/MixinMatchOrders.sol
View File

@@ -63,10 +63,6 @@ contract MixinMatchOrders is
leftOrderInfo.orderHash,
leftOrderInfo.orderFilledAmount
) = getOrderInfo(leftOrder);
if (leftOrderInfo.orderStatus != uint8(Status.ORDER_FILLABLE)) {
emit ExchangeStatus(uint8(leftOrderInfo.orderStatus), leftOrderInfo.orderHash);
return matchedFillResults;
}
// Get right status
OrderInfo memory rightOrderInfo;
@@ -74,10 +70,6 @@ contract MixinMatchOrders is
rightOrderInfo.orderHash,
rightOrderInfo.orderFilledAmount
) = getOrderInfo(rightOrder);
if (rightOrderInfo.orderStatus != uint8(Status.ORDER_FILLABLE)) {
emit ExchangeStatus(uint8(rightOrderInfo.orderStatus), rightOrderInfo.orderHash);
return matchedFillResults;
}
// Fetch taker address
address takerAddress = getCurrentContextAddress();