crowetic/commerce
1
0
Fork 1
mirror of https://github.com/vercel/commerce.git synced 2025-05-17 23:16:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

set dist as the path

Browse Source
This commit is contained in:
Murat Ozcan 2022-05-04 10:37:11 -05:00
parent 9466366dda
commit f770ac60d5
4 changed files with 26 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
.github/workflows/main.yml vendored
View File

@ -27,26 +27,29 @@ jobs:
# # pass GitHub token to allow accurately detecting a build vs a re-run build
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
#############################################################################################################################
# Version 2: install in one job, parallelize the e2e jobs
- name: Cypress install
uses: cypress-io/github-action@v2
with:
runTests: false
# probably Vercel relevant. No idea why we have to build anything, so far
# probably Vercel relevant. No idea why we have to build anything
# In version 1, I did not have to build anything to get things to work in CI
# - run: yarn build
# env:
# COMMERCE_PROVIDER: ${{ secrets.COMMERCE_PROVIDER }}
# NEXT_PUBLIC_SHOPIFY_STORE_DOMAIN: ${{ secrets.NEXT_PUBLIC_SHOPIFY_STORE_DOMAIN }}
# NEXT_PUBLIC_SHOPIFY_STOREFRONT_ACCESS_TOKEN: ${{ secrets.NEXT_PUBLIC_SHOPIFY_STOREFRONT_ACCESS_TOKEN }}
# here, without the build job generating an artifact, the test jobs do not really get items related to our store
- run: yarn build
env:
COMMERCE_PROVIDER: ${{ secrets.COMMERCE_PROVIDER }}
NEXT_PUBLIC_SHOPIFY_STORE_DOMAIN: ${{ secrets.NEXT_PUBLIC_SHOPIFY_STORE_DOMAIN }}
NEXT_PUBLIC_SHOPIFY_STOREFRONT_ACCESS_TOKEN: ${{ secrets.NEXT_PUBLIC_SHOPIFY_STOREFRONT_ACCESS_TOKEN }}
# - name: Save build folder
# uses: actions/upload-artifact@v2
# with:
# name: build
# if-no-files-found: error
# path: build
- name: Save build folder
uses: actions/upload-artifact@v2
with:
name: build
if-no-files-found: error
path: dist
ui-chrome-tests:
runs-on: ubuntu-latest
@ -60,11 +63,11 @@ jobs:
uses: actions/checkout@v2
# must be Vercel relevant. No idea why we have to build anything
# - name: Download the build folders
# uses: actions/download-artifact@v2
# with:
# name: build
# path: build
- name: Download the build folders
uses: actions/download-artifact@v2
with:
name: build
path: dist
- name: 'Chrome E2E Tests'
uses: cypress-io/github-action@v2

1
package.json
View File

@ -17,7 +17,6 @@
},
"devDependencies": {
"cypress": "^9.6.0",
"dotenv": "^16.0.0",
"husky": "^7.0.4",
"prettier": "^2.5.1",
"turbo": "^1.1.2"

4
site/comments.md
View File

@ -425,3 +425,7 @@ In the parallelization section, the jobs with `yarn build` and `save build folde
__________
Unsure about any of the `build` instructions. The yml at the end of Part 5 does not work as advertised. The build job does not generate a build path and errors out. We should just be able to install and cache to perpetual jobs in an easy way without having to crud the build folder.
https://github.com/muratkeremozcan/nextjs-cypress/runs/6292547384?check_suite_focus=true

4
site/tsconfig.json
View File

@ -23,8 +23,8 @@
"@components/*": ["components/*"],
"@commerce": ["../packages/commerce/src"],
"@commerce/*": ["../packages/commerce/src/*"],
"@framework": ["../packages/shopify/src"],
"@framework/*": ["../packages/shopify/src/*"]
"@framework": ["../packages/local/src"],
"@framework/*": ["../packages/local/src/*"]
}
},
"include": ["next-env.d.ts", "**/*.d.ts", "**/*.ts", "**/*.tsx", "**/*.js"],