crowetic/commerce
1
0
Fork 1
mirror of https://github.com/vercel/commerce.git synced 2025-05-17 23:16:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

first attempt took 20 minutes and did not complete, this is 2nd

Browse Source
This commit is contained in:
Murat Ozcan 2022-05-04 11:07:58 -05:00
parent b6d5277cc7
commit cd462f0bed
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
site/comments.md
View File

@ -424,7 +424,11 @@ In the parallelization section, the jobs with `yarn build` and `save build folde
__________
Unsure about any of the `build` instructions. The yml at the end of Part 5 does not work as advertised. The build job does not generate a build path and errors out.
Unsure about any of the `build` instructions. The yml at the end of Part 5 does not work as advertised. The build job does not generate a build path and errors out. I believe having to create this build folder is a vercel related practice, and does not apply to React, Angular or Vue. That needs to be mentioned saying the build, save build, and restore build steps would not be relevant in React, Angular, or Vue.
https://github.com/muratkeremozcan/nextjs-cypress/runs/6292547384?check_suite_focus=true
Instead of `path: build` in the yml, used `path: ./packages/**/dist/**` . This got things to work. However parallel e2e tests did not start in 18 minutes. This yml cannot be optimal
https://github.com/muratkeremozcan/nextjs-cypress/runs/6292906819?check_suite_focus=true