crowetic/commerce
1
0
Fork 1
mirror of https://github.com/vercel/commerce.git synced 2025-05-18 15:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improved DX when editing packages

Browse Source
This commit is contained in:
LFades 2022-01-12 02:51:03 -05:00
parent debcc8c343
commit 1fb20ca2c9
3 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
site/commerce-config.js
View File

@ -66,10 +66,10 @@ function withCommerceConfig(nextConfig = {}) {
// -> /node_modules/[name]/dist/index.js // -> /node_modules/[name]/dist/index.js
const absolutePath = require.resolve(provider) const absolutePath = require.resolve(provider)
// but we want references to go to the real path in /packages instead // but we want references to go to the real path in /packages instead
// -> packages/[name]/dist/index.js // -> packages/[name]/dist
const relativePath = path.relative(process.cwd(), absolutePath) const distPath = path.join(path.relative(process.cwd(), absolutePath), '..')
// -> /packages/[name]/src // -> /packages/[name]/src
const modulePath = path.join(relativePath, '../../src') const modulePath = path.join(distPath, '../src')
tsconfig.compilerOptions.paths['@framework'] = [`${modulePath}`] tsconfig.compilerOptions.paths['@framework'] = [`${modulePath}`]
tsconfig.compilerOptions.paths['@framework/*'] = [`${modulePath}/*`] tsconfig.compilerOptions.paths['@framework/*'] = [`${modulePath}/*`]
@ -78,6 +78,25 @@ function withCommerceConfig(nextConfig = {}) {
tsconfigPath, tsconfigPath,
prettier.format(JSON.stringify(tsconfig), { parser: 'json' }) prettier.format(JSON.stringify(tsconfig), { parser: 'json' })
) )
const webpack = config.webpack
// To improve the DX of using references, we'll switch from `src` to `dist`
// only for webpack so imports resolve correctly but typechecking goes to `src`
config.webpack = (cfg, options) => {
if (Array.isArray(cfg.resolve.plugins)) {
const jsconfigPaths = cfg.resolve.plugins.find(
(plugin) => plugin.constructor.name === 'JsConfigPathsPlugin'
)
if (jsconfigPaths) {
jsconfigPaths.paths['@framework'] = [distPath]
jsconfigPaths.paths['@framework/*'] = [`${distPath}/*`]
}
}
return webpack ? webpack(cfg, options) : cfg
}
} }
return core.withCommerceConfig(config) return core.withCommerceConfig(config)

2
site/components/wishlist/WishlistCard/WishlistCard.tsx
View File

@ -11,7 +11,7 @@ import type { Product } from '@commerce/types/product'
import usePrice from '@framework/product/use-price' import usePrice from '@framework/product/use-price'
import useAddItem from '@framework/cart/use-add-item' import useAddItem from '@framework/cart/use-add-item'
import useRemoveItem from '@framework/wishlist/use-remove-item' import useRemoveItem from '@framework/wishlist/use-remove-item'
import { Wishlist } from '@commerce/types/wishlist' import type { Wishlist } from '@commerce/types/wishlist'
interface Props { interface Props {
item: Wishlist item: Wishlist

4
site/tsconfig.json
View File

@ -21,8 +21,8 @@
"@config/*": ["config/*"], "@config/*": ["config/*"],
"@assets/*": ["assets/*"], "@assets/*": ["assets/*"],
"@components/*": ["components/*"], "@components/*": ["components/*"],
"@commerce": ["framework/commerce"], "@commerce": ["../packages/commerce/src"],
"@commerce/*": ["framework/commerce/*"], "@commerce/*": ["../packages/commerce/src/*"],
"@framework": ["../packages/local/src"], "@framework": ["../packages/local/src"],
"@framework/*": ["../packages/local/src/*"] "@framework/*": ["../packages/local/src/*"]
} }