From 778ac35ee6b797f52c68bd90c0901e7602c8df2e Mon Sep 17 00:00:00 2001
From: catbref <misc-github@talk2dom.com>
Date: Tue, 1 Dec 2020 15:04:50 +0000
Subject: [PATCH] Improve HSQLDBRepository.temporaryValuesTableSql to work with
 Collection, not just List

---
 .../qortal/repository/hsqldb/HSQLDBRepository.java   | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/qortal/repository/hsqldb/HSQLDBRepository.java b/src/main/java/org/qortal/repository/hsqldb/HSQLDBRepository.java
index a282614e..18643559 100644
--- a/src/main/java/org/qortal/repository/hsqldb/HSQLDBRepository.java
+++ b/src/main/java/org/qortal/repository/hsqldb/HSQLDBRepository.java
@@ -16,6 +16,7 @@ import java.sql.Savepoint;
 import java.sql.Statement;
 import java.util.ArrayDeque;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.Deque;
@@ -820,15 +821,18 @@ public class HSQLDBRepository implements Repository {
 	 * <p>
 	 * (Convenience method for HSQLDB repository subclasses).
 	 */
-	/* package */ static void temporaryValuesTableSql(StringBuilder stringBuilder, List<? extends Object> values, String tableName, String columnName) {
+	/* package */ static void temporaryValuesTableSql(StringBuilder stringBuilder, Collection<?> values, String tableName, String columnName) {
 		stringBuilder.append("(VALUES ");
 
-		for (int i = 0; i < values.size(); ++i) {
-			if (i != 0)
+		boolean first = true;
+		for (Object value : values) {
+			if (first)
+				first = false;
+			else
 				stringBuilder.append(", ");
 
 			stringBuilder.append("(");
-			stringBuilder.append(values.get(i));
+			stringBuilder.append(value);
 			stringBuilder.append(")");
 		}