* update abi-gen with new method interfaces * wip: get all packages to build * wip: get all packages to build * Fix two contract wrapper calls * Export necessary types part of the contract wrapper public interfaces * Revive and fix wrapper_unit_tests * Remove duplicate type * Fix lib_exchange_rich_error_decoder tests * Fix remaining test failures in contracts-* packages * Prettier fixes * remove transactionHelper * lint and update changelogs * Fix prettier * Revert changes to reference docs * Add back changelog already published and add revert changelog entry * Add missing CHANGELOG entries * Add missing comma * Update mesh-rpc-client dep * Update Mesh RPC logic in @0x/orderbook to v6.0.1-beta * Align package versions
138 lines
6.4 KiB
TypeScript
138 lines
6.4 KiB
TypeScript
import { blockchainTests, constants, expect } from '@0x/contracts-test-utils';
|
|
import { BigNumber, OwnableRevertErrors } from '@0x/utils';
|
|
import { LogWithDecodedArgs } from 'ethereum-types';
|
|
|
|
import { artifacts } from './artifacts';
|
|
import {
|
|
ExchangeContract,
|
|
ExchangeProtocolFeeCollectorAddressEventArgs,
|
|
ExchangeProtocolFeeMultiplierEventArgs,
|
|
} from './wrappers';
|
|
|
|
blockchainTests.resets('MixinProtocolFees', env => {
|
|
let accounts: string[];
|
|
let exchange: ExchangeContract;
|
|
let nonOwner: string;
|
|
let owner: string;
|
|
let protocolFeeCollector: string;
|
|
|
|
// The protocolFeeMultiplier that will be used to test the update functions.
|
|
const protocolFeeMultiplier = new BigNumber(15000);
|
|
|
|
before(async () => {
|
|
accounts = await env.web3Wrapper.getAvailableAddressesAsync();
|
|
owner = accounts[0];
|
|
nonOwner = accounts[1];
|
|
protocolFeeCollector = accounts[2];
|
|
|
|
// Update the from address of the txDefaults. This is the address that will become the owner.
|
|
env.txDefaults.from = owner;
|
|
|
|
// Deploy the exchange contract.
|
|
exchange = await ExchangeContract.deployFrom0xArtifactAsync(
|
|
artifacts.Exchange,
|
|
env.provider,
|
|
env.txDefaults,
|
|
{},
|
|
new BigNumber(1337),
|
|
);
|
|
});
|
|
|
|
blockchainTests.resets('setProtocolFeeMultiplier', () => {
|
|
it('should revert if msg.sender != owner', async () => {
|
|
const expectedError = new OwnableRevertErrors.OnlyOwnerError(nonOwner, owner);
|
|
|
|
// Ensure that the transaction reverts with the expected rich error.
|
|
const tx = exchange.setProtocolFeeCollectorAddress(protocolFeeCollector).sendTransactionAsync({
|
|
from: nonOwner,
|
|
});
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should succeed and emit an ProtocolFeeMultiplier event if msg.sender == owner', async () => {
|
|
// Call the `setProtocolFeeMultiplier()` function and get the receipt.
|
|
const receipt = await exchange
|
|
.setProtocolFeeMultiplier(protocolFeeMultiplier)
|
|
.awaitTransactionSuccessAsync({
|
|
from: owner,
|
|
});
|
|
|
|
// Verify that the protocolFeeCollector address was actually updated to the correct address.
|
|
const updated = await exchange.protocolFeeMultiplier().callAsync();
|
|
expect(updated).bignumber.to.be.eq(protocolFeeMultiplier);
|
|
|
|
// Ensure that the correct `ProtocolFeeCollectorAddress` event was logged.
|
|
// tslint:disable:no-unnecessary-type-assertion
|
|
const updatedEvent = receipt.logs[0] as LogWithDecodedArgs<ExchangeProtocolFeeMultiplierEventArgs>;
|
|
expect(updatedEvent.event).to.be.eq('ProtocolFeeMultiplier');
|
|
expect(updatedEvent.args.oldProtocolFeeMultiplier).bignumber.to.be.eq(constants.ZERO_AMOUNT);
|
|
expect(updatedEvent.args.updatedProtocolFeeMultiplier).bignumber.to.be.eq(protocolFeeMultiplier);
|
|
});
|
|
});
|
|
|
|
blockchainTests.resets('setProtocolFeeCollectorAddress', () => {
|
|
it('should revert if msg.sender != owner', async () => {
|
|
const expectedError = new OwnableRevertErrors.OnlyOwnerError(nonOwner, owner);
|
|
|
|
// Ensure that the transaction reverts with the expected rich error.
|
|
const tx = exchange.setProtocolFeeCollectorAddress(protocolFeeCollector).sendTransactionAsync({
|
|
from: nonOwner,
|
|
});
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should succeed and emit an ProtocolFeeCollectorAddress event if msg.sender == owner', async () => {
|
|
// Call the `setProtocolFeeCollectorAddress()` function and get the receipt.
|
|
const receipt = await exchange
|
|
.setProtocolFeeCollectorAddress(protocolFeeCollector)
|
|
.awaitTransactionSuccessAsync({
|
|
from: owner,
|
|
});
|
|
|
|
// Verify that the protocolFeeCollector address was actually updated to the correct address.
|
|
const updated = await exchange.protocolFeeCollector().callAsync();
|
|
expect(updated).to.be.eq(protocolFeeCollector);
|
|
|
|
// Ensure that the correct `UpdatedProtocolFeeCollectorAddress` event was logged.
|
|
// tslint:disable:no-unnecessary-type-assertion
|
|
const updatedEvent = receipt.logs[0] as LogWithDecodedArgs<ExchangeProtocolFeeCollectorAddressEventArgs>;
|
|
expect(updatedEvent.event).to.be.eq('ProtocolFeeCollectorAddress');
|
|
expect(updatedEvent.args.oldProtocolFeeCollector).to.be.eq(constants.NULL_ADDRESS);
|
|
expect(updatedEvent.args.updatedProtocolFeeCollector).to.be.eq(protocolFeeCollector);
|
|
});
|
|
});
|
|
|
|
blockchainTests.resets('detachProtocolFeeCollector', () => {
|
|
it('should revert if msg.sender != owner', async () => {
|
|
const expectedError = new OwnableRevertErrors.OnlyOwnerError(nonOwner, owner);
|
|
|
|
// Ensure that the transaction reverts with the expected rich error.
|
|
const tx = exchange.detachProtocolFeeCollector().sendTransactionAsync({
|
|
from: nonOwner,
|
|
});
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should succeed and emit an ProtocolFeeCollectorAddress event if msg.sender == owner', async () => {
|
|
await exchange.setProtocolFeeCollectorAddress(protocolFeeCollector).awaitTransactionSuccessAsync({
|
|
from: owner,
|
|
});
|
|
|
|
const receipt = await exchange.detachProtocolFeeCollector().awaitTransactionSuccessAsync({
|
|
from: owner,
|
|
});
|
|
|
|
// Verify that the protocolFeeCollector address was actually updated to the correct address.
|
|
const updated = await exchange.protocolFeeCollector().callAsync();
|
|
expect(updated).to.be.eq(constants.NULL_ADDRESS);
|
|
|
|
// Ensure that the correct `UpdatedProtocolFeeCollectorAddress` event was logged.
|
|
// tslint:disable:no-unnecessary-type-assertion
|
|
const updatedEvent = receipt.logs[0] as LogWithDecodedArgs<ExchangeProtocolFeeCollectorAddressEventArgs>;
|
|
expect(updatedEvent.event).to.be.eq('ProtocolFeeCollectorAddress');
|
|
expect(updatedEvent.args.oldProtocolFeeCollector).to.be.eq(protocolFeeCollector);
|
|
expect(updatedEvent.args.updatedProtocolFeeCollector).to.be.eq(constants.NULL_ADDRESS);
|
|
});
|
|
});
|
|
});
|