* add LibERC721Order.sol * Add ERC721 interface to vendor/ * Add ERC721OrdersFeature interface * Storage lib for ERC721 orders feature * Implement basic functionality for ERC721 orders (buy, sell, cancel, etc) * Add isValidERC721OrderSignature to interface * implement onERC721Received * Implement batchBuyERC721s * left/right orders -> sell/buy orders * Add missing @return comments * Implement matching functions * Use SafeMath where necessary * add rich errors for ERC721OrdersFeature * Add comments * Add presign support for ERC721 orders * Cancel using just the order nonce * Add IERC721OrdersFeature to IZeroEx * Add taker callback * Assembly optimizations in LibERC721Order * Add ERC721Orders TS class * create zero-ex/contracts/test/integration/ and tokens/ directories * TestMintableERC721Token * tmp * address feedback from original PR (#391) * address feedback from original PR * Update contracts/zero-ex/contracts/src/features/ERC721OrdersFeature.sol Co-authored-by: Kim Persson <kimpers@users.noreply.github.com> * address review feedback and improve order parameter naming * Add batchCancel function * Emit order fields in preSign * Fix tests Co-authored-by: Lawrence Forman <me@merklejerk.com> Co-authored-by: Kim Persson <kimpers@users.noreply.github.com> Co-authored-by: Michael Zhu <mchl.zhu.96@gmail.com> * Remove revertIfIncomplete from batchMatch * Sanity check maker address in preSign * ERC1155OrdersFeature contracts * Commence refactor, abstract base contract * ERC721OrdersFeature inherits from NFTOrders * Refactor ERC1155OrdersFeature to inherit from NFTOrders * Fix order hashing * Fix ERC721OrdersFeature tests * Typos * Remove maker address from preSigned mapping * disable dex sampler tests * Refactor TS tooling * Address PR feedback * Rearrange event fields to better align with struct fields * Update comments * update AbiEncoder.create params * Add ERC1155Order to protocol-utils * Add ERC1155OrdersFeeature tests * Bump package versions and regenerate contract wrappers * Add ERC165Feature * NFT orders: address audit findings (#417) * CVF-1: use pragma solidity ^0.6 instead of ^0.6.5 * CVF-11: fix inaccurate comment * CVF-16: Enable taker callbacks for batchBuyERC1155s * CVF-17: use internal call if revertIfIncomplete is true * CVF-21: avoid duplicate SLOAD * CVF-23: merge if statements * CVF-24: Reorder status checks to be consistent with ERC721OrdersFeature * CVF-25: Update unclear comment (canonical hash -> EIP-712 hash) * CVF-31: Document keys of orderState mapping * CVF-45: DRY up fees/properties hashing * CVF-47, CVF-50, CVF-57: calculate properties.length once; hash propertyStructHashArray in-place using assembly * CVF-56: More descriptive names for assembly variables * CVF-71: Update confusing comment about rounding in _payFees * CVF-72: Move ETH assertions outside of loop in _payFees * CVF-74: Move property validation loop to else branch * CVF-82: Update inaccurate comment * CVF-86: Enable taker callbacks for batchBuyERC721s * CVF-87: use internal call if revertIfIncomplete is true * CVF-89: Perform token mismatch checks before stateful operations * CVF-90, CVF-91: Defer ERC20 token mismatch check * CVF-93: Add inline comments for _payFees parameters in matchERC721Orders * CVF-94: Fix comment (Step 7 -> Step 5) * CVF-98: Use binary & operator instead of mod * CVF-99: Update unclear comment (canonical hash -> EIP-712 hash) * CVF-65, CVF-66, CVF-67: Copy params.ethAvailable into local variable; check that ethSpent does not exceed ethAvailable; remove ethAvailable < erc20FillAmount check * CVF-52, CVF-55, CVF-59: calculate fees.length once; hash feeStructHashArray in-place using assembly * CVF-14, CVF-32: OrderState struct; separate storage mapping for 1155 cancellations so orders can be cancelled by nonce * Update changelogs, IZeroEx artifact/wrapper Co-authored-by: Lawrence Forman <lawrence@0xproject.com> Co-authored-by: Lawrence Forman <me@merklejerk.com> Co-authored-by: Kim Persson <kimpers@users.noreply.github.com>
386 lines
12 KiB
Solidity
386 lines
12 KiB
Solidity
// SPDX-License-Identifier: Apache-2.0
|
|
/*
|
|
|
|
Copyright 2020 ZeroEx Intl.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
pragma solidity ^0.6.5;
|
|
pragma experimental ABIEncoderV2;
|
|
|
|
import "@0x/contracts-utils/contracts/src/v06/LibSafeMathV06.sol";
|
|
|
|
|
|
interface IERC721Receiver {
|
|
|
|
/// @notice Handle the receipt of an NFT
|
|
/// @dev The ERC721 smart contract calls this function on the recipient
|
|
/// after a `transfer`. This function MAY throw to revert and reject the
|
|
/// transfer. Return of other than the magic value MUST result in the
|
|
/// transaction being reverted.
|
|
/// Note: the contract address is always the message sender.
|
|
/// @param _operator The address which called `safeTransferFrom` function
|
|
/// @param _from The address which previously owned the token
|
|
/// @param _tokenId The NFT identifier which is being transferred
|
|
/// @param _data Additional data with no specified format
|
|
/// @return `bytes4(keccak256("onERC721Received(address,address,uint256,bytes)"))`
|
|
/// unless throwing
|
|
function onERC721Received(
|
|
address _operator,
|
|
address _from,
|
|
uint256 _tokenId,
|
|
bytes calldata _data
|
|
)
|
|
external
|
|
returns (bytes4);
|
|
}
|
|
|
|
contract TestMintableERC721Token {
|
|
using LibSafeMathV06 for uint256;
|
|
|
|
/// @dev This emits when ownership of any NFT changes by any mechanism.
|
|
/// This event emits when NFTs are created (`from` == 0) and destroyed
|
|
/// (`to` == 0). Exception: during contract creation, any number of NFTs
|
|
/// may be created and assigned without emitting Transfer. At the time of
|
|
/// any transfer, the approved address for that NFT (if any) is reset to none.
|
|
event Transfer(
|
|
address _from,
|
|
address _to,
|
|
uint256 _tokenId
|
|
);
|
|
|
|
/// @dev This emits when the approved address for an NFT is changed or
|
|
/// reaffirmed. The zero address indicates there is no approved address.
|
|
/// When a Transfer event emits, this also indicates that the approved
|
|
/// address for that NFT (if any) is reset to none.
|
|
event Approval(
|
|
address indexed _owner,
|
|
address indexed _approved,
|
|
uint256 indexed _tokenId
|
|
);
|
|
|
|
/// @dev This emits when an operator is enabled or disabled for an owner.
|
|
/// The operator can manage all NFTs of the owner.
|
|
event ApprovalForAll(
|
|
address indexed _owner,
|
|
address indexed _operator,
|
|
bool _approved
|
|
);
|
|
|
|
// Function selector for ERC721Receiver.onERC721Received
|
|
// 0x150b7a02
|
|
bytes4 constant private ERC721_RECEIVED = bytes4(keccak256("onERC721Received(address,address,uint256,bytes)"));
|
|
|
|
// Mapping of tokenId => owner
|
|
mapping (uint256 => address) private owners;
|
|
|
|
// Mapping of tokenId => approved address
|
|
mapping (uint256 => address) private approvals;
|
|
|
|
// Mapping of owner => number of tokens owned
|
|
mapping (address => uint256) private balances;
|
|
|
|
// Mapping of owner => operator => approved
|
|
mapping (address => mapping (address => bool)) private operatorApprovals;
|
|
|
|
/// @dev Function to mint a new token
|
|
/// Reverts if the given token ID already exists
|
|
/// @param _to Address of the beneficiary that will own the minted token
|
|
/// @param _tokenId ID of the token to be minted by the msg.sender
|
|
function mint(address _to, uint256 _tokenId)
|
|
external
|
|
{
|
|
require(
|
|
_to != address(0),
|
|
"ERC721_ZERO_TO_ADDRESS"
|
|
);
|
|
|
|
address owner = owners[_tokenId];
|
|
require(
|
|
owner == address(0),
|
|
"ERC721_OWNER_ALREADY_EXISTS"
|
|
);
|
|
|
|
owners[_tokenId] = _to;
|
|
balances[_to] = balances[_to].safeAdd(1);
|
|
|
|
emit Transfer(
|
|
address(0),
|
|
_to,
|
|
_tokenId
|
|
);
|
|
}
|
|
|
|
/// @dev Function to burn a token
|
|
/// Reverts if the given token ID doesn't exist
|
|
/// @param _owner Owner of token with given token ID
|
|
/// @param _tokenId ID of the token to be burned by the msg.sender
|
|
function burn(address _owner, uint256 _tokenId)
|
|
external
|
|
{
|
|
require(
|
|
_owner != address(0),
|
|
"ERC721_ZERO_OWNER_ADDRESS"
|
|
);
|
|
|
|
address owner = owners[_tokenId];
|
|
require(
|
|
owner == _owner,
|
|
"ERC721_OWNER_MISMATCH"
|
|
);
|
|
|
|
owners[_tokenId] = address(0);
|
|
balances[_owner] = balances[_owner].safeSub(1);
|
|
|
|
emit Transfer(
|
|
_owner,
|
|
address(0),
|
|
_tokenId
|
|
);
|
|
}
|
|
|
|
/// @notice Transfers the ownership of an NFT from one address to another address
|
|
/// @dev Throws unless `msg.sender` is the current owner, an authorized
|
|
/// operator, or the approved address for this NFT. Throws if `_from` is
|
|
/// not the current owner. Throws if `_to` is the zero address. Throws if
|
|
/// `_tokenId` is not a valid NFT. When transfer is complete, this function
|
|
/// checks if `_to` is a smart contract (code size > 0). If so, it calls
|
|
/// `onERC721Received` on `_to` and throws if the return value is not
|
|
/// `bytes4(keccak256("onERC721Received(address,address,uint256,bytes)"))`.
|
|
/// @param _from The current owner of the NFT
|
|
/// @param _to The new owner
|
|
/// @param _tokenId The NFT to transfer
|
|
/// @param _data Additional data with no specified format, sent in call to `_to`
|
|
function safeTransferFrom(
|
|
address _from,
|
|
address _to,
|
|
uint256 _tokenId,
|
|
bytes calldata _data
|
|
)
|
|
external
|
|
{
|
|
transferFrom(
|
|
_from,
|
|
_to,
|
|
_tokenId
|
|
);
|
|
|
|
uint256 receiverCodeSize;
|
|
assembly {
|
|
receiverCodeSize := extcodesize(_to)
|
|
}
|
|
if (receiverCodeSize > 0) {
|
|
bytes4 selector = IERC721Receiver(_to).onERC721Received(
|
|
msg.sender,
|
|
_from,
|
|
_tokenId,
|
|
_data
|
|
);
|
|
require(
|
|
selector == ERC721_RECEIVED,
|
|
"ERC721_INVALID_SELECTOR"
|
|
);
|
|
}
|
|
}
|
|
|
|
/// @notice Transfers the ownership of an NFT from one address to another address
|
|
/// @dev This works identically to the other function with an extra data parameter,
|
|
/// except this function just sets data to "".
|
|
/// @param _from The current owner of the NFT
|
|
/// @param _to The new owner
|
|
/// @param _tokenId The NFT to transfer
|
|
function safeTransferFrom(
|
|
address _from,
|
|
address _to,
|
|
uint256 _tokenId
|
|
)
|
|
external
|
|
{
|
|
transferFrom(
|
|
_from,
|
|
_to,
|
|
_tokenId
|
|
);
|
|
|
|
uint256 receiverCodeSize;
|
|
assembly {
|
|
receiverCodeSize := extcodesize(_to)
|
|
}
|
|
if (receiverCodeSize > 0) {
|
|
bytes4 selector = IERC721Receiver(_to).onERC721Received(
|
|
msg.sender,
|
|
_from,
|
|
_tokenId,
|
|
""
|
|
);
|
|
require(
|
|
selector == ERC721_RECEIVED,
|
|
"ERC721_INVALID_SELECTOR"
|
|
);
|
|
}
|
|
}
|
|
|
|
/// @notice Change or reaffirm the approved address for an NFT
|
|
/// @dev The zero address indicates there is no approved address.
|
|
/// Throws unless `msg.sender` is the current NFT owner, or an authorized
|
|
/// operator of the current owner.
|
|
/// @param _approved The new approved NFT controller
|
|
/// @param _tokenId The NFT to approve
|
|
function approve(address _approved, uint256 _tokenId)
|
|
external
|
|
{
|
|
address owner = ownerOf(_tokenId);
|
|
require(
|
|
msg.sender == owner || isApprovedForAll(owner, msg.sender),
|
|
"ERC721_INVALID_SENDER"
|
|
);
|
|
|
|
approvals[_tokenId] = _approved;
|
|
emit Approval(
|
|
owner,
|
|
_approved,
|
|
_tokenId
|
|
);
|
|
}
|
|
|
|
/// @notice Enable or disable approval for a third party ("operator") to manage
|
|
/// all of `msg.sender`'s assets
|
|
/// @dev Emits the ApprovalForAll event. The contract MUST allow
|
|
/// multiple operators per owner.
|
|
/// @param _operator Address to add to the set of authorized operators
|
|
/// @param _approved True if the operator is approved, false to revoke approval
|
|
function setApprovalForAll(address _operator, bool _approved)
|
|
external
|
|
{
|
|
operatorApprovals[msg.sender][_operator] = _approved;
|
|
emit ApprovalForAll(
|
|
msg.sender,
|
|
_operator,
|
|
_approved
|
|
);
|
|
}
|
|
|
|
/// @notice Count all NFTs assigned to an owner
|
|
/// @dev NFTs assigned to the zero address are considered invalid, and this
|
|
/// function throws for queries about the zero address.
|
|
/// @param _owner An address for whom to query the balance
|
|
/// @return The number of NFTs owned by `_owner`, possibly zero
|
|
function balanceOf(address _owner)
|
|
external
|
|
view
|
|
returns (uint256)
|
|
{
|
|
require(
|
|
_owner != address(0),
|
|
"ERC721_ZERO_OWNER"
|
|
);
|
|
return balances[_owner];
|
|
}
|
|
|
|
/// @notice Transfer ownership of an NFT -- THE CALLER IS RESPONSIBLE
|
|
/// TO CONFIRM THAT `_to` IS CAPABLE OF RECEIVING NFTS OR ELSE
|
|
/// THEY MAY BE PERMANENTLY LOST
|
|
/// @dev Throws unless `msg.sender` is the current owner, an authorized
|
|
/// operator, or the approved address for this NFT. Throws if `_from` is
|
|
/// not the current owner. Throws if `_to` is the zero address. Throws if
|
|
/// `_tokenId` is not a valid NFT.
|
|
/// @param _from The current owner of the NFT
|
|
/// @param _to The new owner
|
|
/// @param _tokenId The NFT to transfer
|
|
function transferFrom(
|
|
address _from,
|
|
address _to,
|
|
uint256 _tokenId
|
|
)
|
|
public
|
|
{
|
|
require(
|
|
_to != address(0),
|
|
"ERC721_ZERO_TO_ADDRESS"
|
|
);
|
|
|
|
address owner = ownerOf(_tokenId);
|
|
require(
|
|
_from == owner,
|
|
"ERC721_OWNER_MISMATCH"
|
|
);
|
|
|
|
address spender = msg.sender;
|
|
address approvedAddress = getApproved(_tokenId);
|
|
require(
|
|
spender == owner ||
|
|
isApprovedForAll(owner, spender) ||
|
|
approvedAddress == spender,
|
|
"ERC721_INVALID_SPENDER"
|
|
);
|
|
|
|
if (approvedAddress != address(0)) {
|
|
approvals[_tokenId] = address(0);
|
|
}
|
|
|
|
owners[_tokenId] = _to;
|
|
balances[_from] = balances[_from].safeSub(1);
|
|
balances[_to] = balances[_to].safeAdd(1);
|
|
|
|
emit Transfer(
|
|
_from,
|
|
_to,
|
|
_tokenId
|
|
);
|
|
}
|
|
|
|
/// @notice Find the owner of an NFT
|
|
/// @dev NFTs assigned to zero address are considered invalid, and queries
|
|
/// about them do throw.
|
|
/// @param _tokenId The identifier for an NFT
|
|
/// @return The address of the owner of the NFT
|
|
function ownerOf(uint256 _tokenId)
|
|
public
|
|
view
|
|
returns (address)
|
|
{
|
|
address owner = owners[_tokenId];
|
|
require(
|
|
owner != address(0),
|
|
"ERC721_ZERO_OWNER"
|
|
);
|
|
return owner;
|
|
}
|
|
|
|
/// @notice Get the approved address for a single NFT
|
|
/// @dev Throws if `_tokenId` is not a valid NFT.
|
|
/// @param _tokenId The NFT to find the approved address for
|
|
/// @return The approved address for this NFT, or the zero address if there is none
|
|
function getApproved(uint256 _tokenId)
|
|
public
|
|
view
|
|
returns (address)
|
|
{
|
|
return approvals[_tokenId];
|
|
}
|
|
|
|
/// @notice Query if an address is an authorized operator for another address
|
|
/// @param _owner The address that owns the NFTs
|
|
/// @param _operator The address that acts on behalf of the owner
|
|
/// @return True if `_operator` is an approved operator for `_owner`, false otherwise
|
|
function isApprovedForAll(address _owner, address _operator)
|
|
public
|
|
view
|
|
returns (bool)
|
|
{
|
|
return operatorApprovals[_owner][_operator];
|
|
}
|
|
}
|