protocol/contracts/zero-ex/test/initial_migration_test.ts
Lawrence Forman 548c30d6a0
ZeroEx: Audit Fixes (#2586)
* `@0x/utils`: Remove unused revert error.

* `@0x/contracts-zero-ex`: Address audit feedback.
2020-05-26 20:57:55 -04:00

106 lines
4.1 KiB
TypeScript

import { blockchainTests, expect, randomAddress } from '@0x/contracts-test-utils';
import { hexUtils, ZeroExRevertErrors } from '@0x/utils';
import { artifacts } from './artifacts';
import { BootstrapFeatures, deployBootstrapFeaturesAsync, toFeatureAdddresses } from './utils/migration';
import {
IBootstrapContract,
InitialMigrationContract,
IOwnableContract,
SimpleFunctionRegistryContract,
TestInitialMigrationContract,
ZeroExContract,
} from './wrappers';
blockchainTests.resets('Initial migration', env => {
let owner: string;
let zeroEx: ZeroExContract;
let migrator: TestInitialMigrationContract;
let bootstrapFeature: IBootstrapContract;
let features: BootstrapFeatures;
before(async () => {
[owner] = await env.getAccountAddressesAsync();
features = await deployBootstrapFeaturesAsync(env.provider, env.txDefaults);
migrator = await TestInitialMigrationContract.deployFrom0xArtifactAsync(
artifacts.TestInitialMigration,
env.provider,
env.txDefaults,
artifacts,
env.txDefaults.from as string,
);
bootstrapFeature = new IBootstrapContract(
await migrator.bootstrapFeature().callAsync(),
env.provider,
env.txDefaults,
{},
);
const deployCall = migrator.deploy(owner, toFeatureAdddresses(features));
zeroEx = new ZeroExContract(await deployCall.callAsync(), env.provider, env.txDefaults);
await deployCall.awaitTransactionSuccessAsync();
});
it('Self-destructs after deployment', async () => {
const dieRecipient = await migrator.dieRecipient().callAsync();
expect(dieRecipient).to.eq(owner);
});
it('Non-deployer cannot call deploy()', async () => {
const notDeployer = randomAddress();
const tx = migrator.deploy(owner, toFeatureAdddresses(features)).callAsync({ from: notDeployer });
return expect(tx).to.revertWith('InitialMigration/INVALID_SENDER');
});
it('External contract cannot call die()', async () => {
const _migrator = await InitialMigrationContract.deployFrom0xArtifactAsync(
artifacts.InitialMigration,
env.provider,
env.txDefaults,
artifacts,
env.txDefaults.from as string,
);
const tx = _migrator.die(owner).callAsync();
return expect(tx).to.revertWith('InitialMigration/INVALID_SENDER');
});
describe('bootstrapping', () => {
it('Migrator cannot call bootstrap() again', async () => {
const tx = migrator.callBootstrap(zeroEx.address).awaitTransactionSuccessAsync();
const selector = bootstrapFeature.getSelector('bootstrap');
return expect(tx).to.revertWith(new ZeroExRevertErrors.Proxy.NotImplementedError(selector));
});
it('Bootstrap feature self destructs after deployment', async () => {
const doesExist = await env.web3Wrapper.doesContractExistAtAddressAsync(bootstrapFeature.address);
expect(doesExist).to.eq(false);
});
});
describe('Ownable feature', () => {
let ownable: IOwnableContract;
before(async () => {
ownable = new IOwnableContract(zeroEx.address, env.provider, env.txDefaults);
});
it('has the correct owner', async () => {
const actualOwner = await ownable.owner().callAsync();
expect(actualOwner).to.eq(owner);
});
});
describe('SimpleFunctionRegistry feature', () => {
let registry: SimpleFunctionRegistryContract;
before(async () => {
registry = new SimpleFunctionRegistryContract(zeroEx.address, env.provider, env.txDefaults);
});
it('_extendSelf() is deregistered', async () => {
const selector = registry.getSelector('_extendSelf');
const tx = registry._extendSelf(hexUtils.random(4), randomAddress()).callAsync({ from: zeroEx.address });
return expect(tx).to.revertWith(new ZeroExRevertErrors.Proxy.NotImplementedError(selector));
});
});
});