Lawrence Forman
20d8c1b51a
In @0x/contracts-exchange
: Update tests for rich reverts
2019-07-23 15:17:56 -07:00
Lawrence Forman
4408604c2d
In @0x/contracts-exchange
: upgrading tests...
2019-07-23 15:17:56 -07:00
Lawrence Forman
15db5c8059
In @0x/contracts-exchange
: Fix busted TestAssetProxyDispatcher.sol
2019-07-23 15:17:56 -07:00
Lawrence Forman
c36dff6354
In @0x/contracts-exchange
: Fix dispatchTransferFrom
so it preserves the assetData.
2019-07-23 15:17:56 -07:00
Lawrence Forman
f06f0785f1
In @0x/contracts-test-utils
: Inherit OrderStatus
from @0x/types
2019-07-23 15:17:28 -07:00
Lawrence Forman
79cf9156eb
In @0x/contracts-test-utils
add generatePseudoRandomOrderHash()
to orderUtils
.
2019-07-23 15:16:49 -07:00
Lawrence Forman
3a6664282c
In @0x/contracts-exchange
: fix contract bugs introduced by changes
2019-07-23 15:16:49 -07:00
Lawrence Forman
5b25eb4fbd
Fix linter errors.
2019-07-23 15:15:17 -07:00
Lawrence Forman
371dc347cc
Inherit chaiSetup
from @0x/dev-utils
2019-07-23 15:13:26 -07:00
Lawrence Forman
e8ecbe32ca
Convert exchange
MixinWrapperFunctions
to use rich reverts
2019-07-23 15:10:31 -07:00
Lawrence Forman
bc5c5050fb
Convert MixinTransactions
to use rich reverts
2019-07-23 15:10:31 -07:00
Lawrence Forman
8a9b9c55ce
Convert MixinSignatureValidator
to use rich reverts
2019-07-23 15:10:31 -07:00
Lawrence Forman
d40f343d2a
Convert MixinMatchOrders
to use rich reverts
2019-07-23 15:10:31 -07:00
Lawrence Forman
4954d0a018
Convert MixinExchangeCore
to use rich errors.
2019-07-23 15:10:31 -07:00
Lawrence Forman
7232bef07b
Change LibRichErrors
to just RichErrors
.
...
Fix compilation issues in `exchange`.
2019-07-23 15:10:31 -07:00
Lawrence Forman
7277fb3d93
Convert to use rich reverts
2019-07-23 15:10:31 -07:00
Lawrence Forman
34e0345b29
Reimplementing rich reverts in the contracts.
2019-07-23 15:10:31 -07:00
Amir Bandeali
f094e9118c
Fix inconsistent pragma for ABIEncoderV2
2019-07-23 15:10:31 -07:00
Amir Bandeali
63e93d9253
Update CHANGELOGs
2019-07-23 15:10:31 -07:00
Amir Bandeali
2ec0d421f7
Cleanup LibEIP712 domain contracts
2019-07-23 15:09:46 -07:00
Amir Bandeali
8ddc890e10
Refactor BalanceThresholdFilter to use new ITransaction interface
2019-07-23 15:09:46 -07:00
Amir Bandeali
095c899913
Refactor coordinator to use new ITransactions interface
2019-07-23 15:09:46 -07:00
Amir Bandeali
e0d6a3fd1d
Refactor executeTransaction to take ZeroExTransaction struct as input
2019-07-23 15:09:46 -07:00
Amir Bandeali
308ff15adc
Refactor EIP712 libraries
2019-07-23 15:09:46 -07:00
Lawrence Forman
c195629a77
Update changelogs.
2019-07-23 15:08:58 -07:00
Lawrence Forman
6af5a67a17
Fix import order in contracts/test-utils
2019-07-23 15:08:30 -07:00
Lawrence Forman
0b38289703
Ran prettier
2019-07-23 15:08:30 -07:00
Lawrence Forman
041bf9b54e
Rename orderWithoutExchangeAddress
-> orderWithoutDomain
in contracts/exchange
tests.
2019-07-23 15:08:30 -07:00
Lawrence Forman
5a6cf2b690
Rename orderWithoutExchangeAddress
-> orderWithoutDomain
in contracts/test-utils/.../formatters.ts
.
2019-07-23 15:08:30 -07:00
Lawrence Forman
b8f056b82f
Update coordinator
, exchange-forwarder
, exchange-libs
, exchange
, and extensions
contract tests to use new order and transaction structure
2019-07-23 15:08:00 -07:00
Lawrence Forman
259b463b73
Update contracts/test-utils
to use new Order
structure and domain schema.
2019-07-23 15:08:00 -07:00
Lawrence Forman
53b1037a33
contracts/exchange-libs/contracts/test/TestLibs
now inherits from LibEIP712ExchangeDomain
rather than LibEIP712
2019-07-23 15:04:46 -07:00
Lawrence Forman
2b5cd02bd9
Remove deleted coordinator test contracts that accidentally survived the rebase
2019-07-23 15:04:46 -07:00
Lawrence Forman
e5fed57b8b
Make contracts/exchange-libs/.../LibEIP712.sol
stateless
2019-07-23 15:04:46 -07:00
Lawrence Forman
a0b1f3efa2
Fix typo in exchange-libs
test.
2019-07-23 15:04:46 -07:00
Lawrence Forman
f7fb1225d2
Add more LibEIP712 tests to exchange-libs
2019-07-23 15:04:46 -07:00
Lawrence Forman
b380952ff9
Add test to exchange-libs
to ensure that a different chainId results in a different order hash.
2019-07-23 15:04:46 -07:00
Lawrence Forman
2524e7eea3
Update changelogs
2019-07-23 15:04:46 -07:00
Lawrence Forman
d58d7f457d
Update coordinator decodeOrdersFromFillData
tests to include chainId
2019-07-23 14:59:31 -07:00
Lawrence Forman
77ed54f64d
Ran prettier
2019-07-23 14:58:00 -07:00
Lawrence Forman
e51b425200
Unpin coordinator deps.
...
Update coordinator tests for new tooling.
Remove unecessary `chainId` parameter in `eip712_utils.createCoordinatorApprovalTypeData`
2019-07-23 14:58:00 -07:00
Lawrence Forman
bd06c7b343
Remove lingering invalid calls to OrderStateUtils()
2019-07-23 14:58:00 -07:00
Lawrence Forman
c096eae644
All glory to the linter gods.
2019-07-23 14:58:00 -07:00
Lawrence Forman
35f568e346
Update exchange-forwarder
tests.
2019-07-23 14:58:00 -07:00
Lawrence Forman
2d28fde24d
Migrate all contract-related tooling and tests to accept a chain ID in domain separators.
2019-07-23 14:58:00 -07:00
Lawrence Forman
92fe720ac3
Remove unused LibOrder
inheritance from MixinBalanceThresholdFilterCore
from /contracts/extensions
.
2019-07-23 14:58:00 -07:00
Lawrence Forman
74a9a13564
Unpin @0x/contracts-exchange
dependency in /contracts/coordinator
.
...
Split up EIP712 constants and functionality in `/contracts/exchange-libs` across 3, modular contracts.
Make coordinator inherit from the modular EIP712 contracts in `@0x\contracts-exchange`.
2019-07-23 14:58:00 -07:00
Lawrence Forman
7aaef5d807
Fix missing comma in LibEIP712.sol
domain schema.
...
Add `chainId` to constructors for all test contracts deriving from `LibEIP712.sol`
2019-07-23 14:58:00 -07:00
Lawrence Forman
64b4158bad
Refactor EIP712 contracts to reduce code duplication.
2019-07-23 14:58:00 -07:00
Lawrence Forman
964d8171dd
Update exchange and coordinator contracts to incorporate chainID in their domain separators.
2019-07-23 14:58:00 -07:00