Shared validation and default application can be moved into BaseContract
Assignment before return can be skipped here as it saves a line and
makes a dramatic difference.
Store the functionSignature once and reuse, this saving is large for
Exchange functions with order tuples.
* .gitignore gen'd Python staking contract wrappers
* abi-gen/test-cli: check Python type hints in lint
* sra_client.py: Update doc for replicating examples
* abi-gen/Py: fix call() return type incl. tx hash
Previously, generated wrappers for contract methods were including type
hints that suggested that a call() (as opposed to a send_transaction())
might return either the underlying return type or a transaction hash.
This doesn't make sense because a call() will never return a TX hash.
Now, the type hint just has the return type of the underlying method.
* abi-gen: fix test_cli:lint checking wrong code
test_cli:lint is meant to be a rudimentary test of the code generated by
abi-gen. However, previously, this script was incorporated into `yarn
lint`, and in CircleCI `static-tests` runs independently of `build`.
Consequently, the runs of test_cli:lint were checking the OLD code,
which was previously generated and checked in to git, NOT the code
generated with the version of abi-gen represented by the git repo. Now,
test_cli:lint happens during `yarn test` rather than `yarn lint`,
because `yarn test` IS dependent on `yarn build`.
* contract_wrappers.py: fix misplaced doc
Previously, the routines `order_to_jsdict()` and `jsdict_to_order()`
were moved from contract_wrappers.exchange.types to
contract_wrappers.order_conversions. However, the module-level
docstring describing those routines was accidentally left behind in
exchange.types.
* abi-gen/Py: stop documenting return types for TXs
Previously the send_transaction() interface included docstring
documentation for the return types of the contract method, but that
doesn't make any sense because send_transaction() returns a transaction
hash rather than any actual return values.
* abi-gen/Py: stop gen'ing send_tx for const methods
* abi-gen/Py: add build_tx to contract methods
* abi-gen/Py: fix incorrect method return types
Fixes#2298 .
* abi-gen/Py: rm validator arg to no-input methods
* abi-gen: mv Py Handlebars helpers to own module
Move all existing Python-related Handlebars helpers to the newly created
python_handlebars_helpers module.
* abi-gen: refactor internal interface
No functionality is changed. Sole purpose of this commit is to
facilitate an upcoming commit.
* abi-gen: refactor internal interface
No functionality is changed. Sole purpose of this commit is to
facilitate an upcoming commit.
* abi-gen/Py: name tuples w/internalType, not hash
Use the new `internalType` field on the `DataItem`s in the contract
artifact to give generated tuple classes a better name than just hashing
their component field names.
* Fix CI errors
* abi-gen/Py/wrapper: make internal member private
* Update CHANGELOGs
* update abi-gen with new method interfaces
* wip: get all packages to build
* wip: get all packages to build
* Fix two contract wrapper calls
* Export necessary types part of the contract wrapper public interfaces
* Revive and fix wrapper_unit_tests
* Remove duplicate type
* Fix lib_exchange_rich_error_decoder tests
* Fix remaining test failures in contracts-* packages
* Prettier fixes
* remove transactionHelper
* lint and update changelogs
* Fix prettier
* Revert changes to reference docs
* Add back changelog already published and add revert changelog entry
* Add missing CHANGELOG entries
* Add missing comma
* Update mesh-rpc-client dep
* Update Mesh RPC logic in @0x/orderbook to v6.0.1-beta
* Align package versions
* abi-gen/test: recompile contract fixtures for 3.0
It seems this hadn't been done since the merge with the 3.0 branch.
* Sync `monorepo$ yarn test` exclusions to CI config
* sra-spec: correct typo
* contract-wrappers: TODO after coord.-server update
* utils: fix typo in comment
* Refactor networkId to chainId everywhere
* Update CHANGELOGs
* .gitignore migrations/0x_ganache_snapshot
* .gitignore new-ish Python contract wrappers
These should have been added back when we started generating these
wrappers.
* rm superfluous contract artifact in Python package
All of the contract artifacts were removed from the Python package
recently, because now they're copied from the monorepo/packages area as
an automated build step. Somehow this one artifact slipped through the
cracks.
* Eliminate circular dependency
This was preventing the Exchange wrapper from ever importing its
validator!
* Improve output of monorepo-level parallel script
- Capture stderr (and have it included in stdout) so that it doesn't
leak onto the console for commands that didn't actually fail.
- Include all error output in the Exception object (eliminate print
statement).
* Silence new versions of linters
Newer versions care about this stuff. Old versions didn't, and we don't
either.
* Support Rich Reverts via Web3.py middleware
* Fix bug in generated wrappers' bytes handling
`bytes.fromhex(bytes.decode('utf-8')` is just plain wrong. It would
work for some cases, but is not working when trying to fill orders with
the latest Exchange contract.
* Migrate to Exchange v3
* Fix typo in DevUtils documentation
* Include new contracts in docs
* Re-enable Python checks in CI
* Accept strings for bytes
* Fix CircleCI build artifacts for gen'd python
I swear the previous way was working before, but it wasn't working now,
so this fixes it.
* Accept a provider OR a Web3 object
In various places. This allows the caller to install middleware (which
in web3.py is installed on a Web3 object, not on a provider) before
executing any RPC calls, which is important for the case where one wants
to produce signatures locally before submitting to a remote node.
* wrapper base: don't assume there are accounts
* Eliminate some inline linter directives
* make CHANGELOGs be REVERSE chronological
* Update CHANGELOG entries and bump version numbers
* @0x/contract-addresses: Put addr's in JSON, not TS
This allows easier consumption by other languages. (Specifically, it
eliminates the overhead of keeping the Python addresses package in sync
with the TypeScript one.)
* sra_client.py: incl. docker in `./setup.py clean`
* sra_client.py: Migrate to protocol v3
Removed script that existed only to exclude runs of sra_client builds
(parallel_without_sra_client). Now `parallel` is used by CI,
re-including sra_client in CI checks.
* abi-gen/templates/Py: clarify if/else logic
In response to
https://github.com/0xProject/0x-monorepo/pull/2284#discussion_r342200906
* sra_client.py: Update CHANGELOG and bump version
* contract_addresses/setup.py: rm unnecessary rm
* json_schemas.py: corrections to dev dependencies
* In tests against deployment, also run doctests
* contract_wrappers example: rm xtra Order attribute
Thanks to @steveklebanoff for catching this.
https://github.com/0xProject/0x-monorepo/pull/2284#pullrequestreview-312065368
* introduce --debug option to abi-gen and remove debug functions from @0x/abi-gen-wrappers
* make evmExecAsync protected; ignore deployedBytecode in doc comment
* trim deployedBytecode so it's undefined unless a contract has pure functions
* remove validateAndSendTransactionAsync
* Create `AwaitTransactionSuccessOpts` and `SendTransactionOpts` types
* Remove duplicate types `IndexedFilterValues`, `DecodedLogEvent`, `EventCallback` from `@0x/base-contract`
* Added longer timeout for algolia admin operations. Added an option to apply hidden and custom labels to filters from algolia. Added sorting guides (alphabetically) and tools (by community maintenance and alphabetically).
* Fixed some types in guides
* Updated webpack, webpack-dev-server, webpack-bundle-analyzer, webpack-cli versions
* Updated / cleaned up babel and mdx packages
* Updated terser webpack plugin; Removed uglify plugin (unused). Added parallel option for terser. Added target browsers and cache directory option for babel-loader
* Webpack changes: using eval-source-map for development, added parallel option to Terser plugin, added cache loader and caching directory to mdx / babel loaders.
* Removed unusued pkg: body-scroll-lock
* Removed unused jsonschema / @types/jsonschema packages
* Removed unused less node package, adjusted less loader rules to match other loaders in webpack config
* Removed unusued node-sass package. Left sass-loader for webpack intact.
* Removed unused package react-lazyload
* Removed unused package react-typist
* Removed react-tap-event types as it's not used anymore. Reinstalled node-sass as a dev dependency as it's needed by sass-loader
* Moves @0x/types and @0x/typescript-typings to devDependencies
* Replaced react loadable (only used in Icon) with the native react lazy / suspense. Removed loadable nad its types from package.json
* Removed unused make-promises-safe package
* Moved animations to public and compressed files
* Added opening step links in new tab if the url is valid
* Moved @0x/types back to dependencies.
* Added animation wrapper with positioning props. Updated animations for core concepts.
* Replaced images for core concepts. Fixed a bug causing duplicate props on image and its container in mdx
* Remove legacy FAQ
* Update yarn.lock
* Add MD docs diff test to CI
* Remove unused dep
* Update docs to latest format
* Update yarn.lock
* Update ts-doc-gen with fix for multi-link lines
* Final docs gen
* Fix home route
* Update yarn.lock
* Add Golang Mesh RPC package and update versions
* Update the tools MDX files from authoritative S3 before build and dev server start
* Gitignore the tool MDX files in website repo
* Redirect old docs pages and wiki to new doc pages
* Move out Algolia indexing command-line tool out of website and remove need to expose admin key
* Add updating tools from S3 and indexing content on Algolia to deployment commands
* Add note about admin API env var needed for indexing docs
* Remove scripts gitignore since we don't have monorepo scripts in each package anymore
* Segregate indexes by environment
* Fixed 404 display for docs pages
* Removed webpack bundle analyzer
* Fix search and indexing
* Use `yarn` because otherwise the flags don't get passed down properly
* Improve indexing comment
* Remove legacy doc pages
* Fix linter errors
* Fix clean command to remove bundles recursively
* Revert react and react-dom versions in Instant
* Remove old doc md files
* Fix links
* Fix prettier
* Combine @0x/utils exports
* Update doc links
* Remove unused components
* Fix TS error
* Add missing new line
* Update Guides
* Ignore auto-generated MDX in website repo
* Prettier fix
* Add all guides to the sitemap.txt
* Add MMing guide
* Fix Get Started links
* Add 0x Extensions guide
* Replace all links to wiki with links to guides section
* Fix all /docs/{pkg} links to /docs/tools/{pkg}
* Remove deployer endpoint that is no longer used
* Fix links in Core Concepts
* Fixed regex to not remove hashes on links beyond the initial one
* Fixed huge width on instant screenshot
* Cleaned up core concept illustrations
* Started updating tool titles
* Fixed sectionizing headings in docs: Nested sections do not get wrapped in parent sections anymore; only sectionizing headings that need to be sectionized (i.e. that appear in the table of contents)
* Stylstic fix for the new way we sectionize headings / table of contents
* Change CoordinatorWrapper constructor to take a provider
* Added autolinking headings in mdx docs
* Refactor doc generation script to only generate MD docs and to have them reflect what is exported in their respective index.ts files
* Update ts-doc-gen
* Pass in provider, not Web3Wrapper
* Add back logic to prune out private methods
* Write algolia_metadata to utils dir
* Remove duplicate algolia_meta
* Add more packages to those we generate docs for and remove unused flags
* Update reference.mdx files
* Hide tools from homepage that have isHidden flag
* Link 0x.js to it's reference page
* Update tool naming to be more human readable
* Remove order-watcher reference doc
* Add blurb about on-chain API Explorer
* Add "On-chain" prefix to section name
* Remove committed reference file
* Sorting guides by difficulty and alphabetically
* Pushed sorting guides titles case-insensitive
* Sorting tools by difficulty and alphabetically. Removed icons from featured tools. Extracted common difficultyOrder constant
* Update ts-doc-gen so that it properly converts module relative links to anchor links
* Update doc references
* Remove "Relayers" topic/tag
* Prettier fix
* Remove hr so we don't have a bunch in a row
* Cleaned up CLI tag and added link to tools on API page
* Cleaned up some Guide titles
* Added bug bounty program guide
* Fixed a bug in algolia_meta
* Thrid level of nesting / temporary webpack config
* Open help link in new tab
* Link Python tools to doc pages not PyPi
* Fix links in guides
* Remove unused variables
* Revert webpack config
* Extracted common styles for levels of nesting deeper than 1 in the mdx table of contents
* Smoother animation on active table of contents state change
* Autolink headings in mdx only up to h3. Added heading sizes (in px) for h4,h5,h6 in mdx headings
* Fix prettier
* Adjusted font-size for paragraph, ordered and unordered lists. Fixed line-heights and colors too.
* Update ts-doc-gen and the reference docs
* Replace 0xproject.com urls with 0x.org
* Update README links
* Fix header sizes to display optimally in sidebar
* Fixed an issue with other nodes than text being parsed incorrectly in the table of contents
* Fixed styles for table of contents
* Use a different babel plugin that works in a production webpack build
* Unbroke build process / generating toc
* Changed line-height to 1.6 for paragraph
* Adjust scrollbar / toc height to available space
* Fixed some types
* Remove unnecessary link
* Fix casing on TypeScript
* Fix casing of PyPI
* Remove doc gen from abi-gen-wrappers since it'll be tested via contract-wrappers
* Fix MD docs and make sure generated contract wrappers are being rendered
* Remove generated docs in clean
* Correctly copying code samples
* Several additional fixes to the reference MDX docs
* Changed tools to Tools & Libraries - top nav left as just tools
* Changed references from Asset Buyer to Asset Swapper
* Changed trader keyword to trading
* Nevermind, changed back to Trader
* Sneaking in updated product dropdown menu titles based on Will's feedback
* Removed the word wiki from resources dropdown
* Open legal guide in same window
* Removed the isCommunity filter / custom filter labels functionality (only used for that before)
* Update ts-doc-gen version to one that fixes issues with Object Literals and removes Hierarchy sections and Module headers
* update yarn.lock
* Remove unused code
* Remove unused import
* Remove unused imports
* Remove unused import
* Fix prettier
* Update outdating dep version
* Created a color scheme for code snippets. Fixed language not being passed to some code blocks in two guides.
* Update abi-gen-wrappers dep version
* Update Algolia to production account
* Fix prettier
* Fix prettier in algolia_meta
* Remove packages/dev-tools-pages folder and update yarn.lock
* Remove other random references to dev-tools-pages
* Fix website
* Changed the order of indices in search suggestions
* Removed a comment
* Added scrollbar size adjustment on resize / scroll
* Rendering sidebar on mobile without any event listeners / taxing calculations / changes in height
* Added a performance comment
* Simplified table of contents
* Update ganache-cli to later version
* Remove bundle dirs too
* Added keeping active link in view when scrolling content in the docs
* Increase available memory for webpack
* Update contract addresses
* Update market-making guide to mention Mesh as an alternative to SRA
* Update Web3 Provider Explained guide
* Re-wrote Ganache Setup guide into a Setting up a local 0x testnet guide
* Export more of abi-gen-wrappers from contract-wrappers
* Final update of reference docs
* Add contract-wrappers MD docs and update it's index.ts so that no types are missing
* Fix prettier
* Increase the memory allocation for building the website
* Remove use of remove type
* Check if link is a valid url in mdx inline link: if so, open in a new tab, if not, same tab.
* Print out which snapshot version is being downloaded
* Updated CHANGELOGS & MD docs
* Publish
- @0x/contracts-asset-proxy@2.2.7
- @0x/contracts-coordinator@2.0.12
- @0x/contracts-dev-utils@0.0.9
- @0x/contracts-erc1155@1.1.14
- @0x/contracts-erc20@2.2.13
- @0x/contracts-erc721@2.1.14
- @0x/contracts-exchange-forwarder@3.0.11
- @0x/contracts-exchange-libs@3.0.7
- @0x/contracts-exchange@2.1.13
- @0x/contracts-extensions@4.0.7
- @0x/contracts-multisig@3.1.13
- @0x/contracts-test-utils@3.1.15
- @0x/contracts-utils@3.2.3
- 0x.js@7.0.1
- @0x/abi-gen-wrappers@5.3.1
- @0x/abi-gen@4.2.0
- @0x/assert@2.1.5
- @0x/asset-buyer@6.1.13
- @0x/asset-swapper@1.0.3
- @0x/base-contract@5.3.3
- @0x/connect@5.0.18
- @0x/contract-artifacts@2.2.1
- @0x/contract-wrappers@12.0.0
- @0x/contracts-gen@1.0.14
- @0x/dev-tools-pages@0.0.30
- @0x/dev-utils@2.3.2
- ethereum-types@2.1.5
- @0x/fill-scenarios@3.0.18
- @0x/instant@1.0.30
- @0x/json-schemas@4.0.1
- @0x/migrations@4.3.1
- @0x/monorepo-scripts@1.0.36
- @0x/order-utils@8.3.1
- @0x/sol-compiler@3.1.14
- @0x/sol-coverage@3.0.11
- @0x/sol-doc@2.0.18
- @0x/sol-profiler@3.1.13
- @0x/sol-resolver@2.0.10
- @0x/sol-trace@2.0.19
- @0x/sol-tracing-utils@6.0.18
- @0x/sra-spec@2.0.16
- @0x/subproviders@5.0.3
- @0x/testnet-faucets@1.0.86
- @0x/types@2.4.2
- @0x/typescript-typings@4.2.5
- @0x/utils@4.5.1
- @0x/web3-wrapper@6.0.12
- @0x/website@0.0.89
* Remove the website from the monorepo
* Update yarn.lock
* Remove website files that were accidentally merged back in
* Use local EVM for pure functions (#2108)
* add local evm for pure functions
* increase container size to >=8gb for static-tests
* increase max bundle size because of ethereumjs-vm dependency
* add declarations for ethereumjs-vm in @0x/typescript-typings
* Make `OrdersChannelSubscriptionOpts` conform to SRAv2
* Make it easier to use validateOrderFillableOrThrowAsync (#2096)
* make it easier to use validateOrderFillableOrThrowAsync
* add unit tests, use DevUtils
* remove dependency on @0x/order-utils from @0x/migrations
* add devUtils to contract-wrappers (#2146)
* Delete docs in S3 bucket before uploading latest version so we only ever have one version uploaded at a time
* Update to new ts-doc-gen version that fixes links in "Inherited from" lines
* try to fix instant build
* Remove redoc-cli as a dep from sra-spec
* Smooth out some last incompatible types
* Fix prettier
* Add terser-webpack-plugin to 0x.js deps
* @0x/orderbook
* AssetSwapper to use @0x/orderbook
* Remove unused imported type
* Prevent double websocket connections
* Fix build error
* fixed consumer inconsistency bug
* linted + added convenience functionality
* minor changes/typo fixes
* updated websocket
* updated for prettier
* Fix versions and exported types
* move log tests to @0x/abi-gen; delete exchange_wrapper_test (#2160)
* Remove unused exported types
* Fix exports from asset-swapper
* Update exported types for docs
* Update mesh client dep
* Move perPage and 18 precision lower to re-use
* fix ABI encoding/decoding functions (#2165)
* Fix typo at contract import (#2102)
* Updated CHANGELOGS & MD docs
* Publish
- @0x/contracts-asset-proxy@2.2.8
- @0x/contracts-coordinator@2.0.13
- @0x/contracts-dev-utils@0.0.10
- @0x/contracts-erc1155@1.1.15
- @0x/contracts-erc20@2.2.14
- @0x/contracts-erc721@2.1.15
- @0x/contracts-exchange-forwarder@3.0.12
- @0x/contracts-exchange-libs@3.0.8
- @0x/contracts-exchange@2.1.14
- @0x/contracts-extensions@4.0.8
- @0x/contracts-multisig@3.1.14
- @0x/contracts-test-utils@3.1.16
- @0x/contracts-utils@3.2.4
- 0x.js@7.0.2
- @0x/abi-gen-wrappers@5.3.2
- @0x/abi-gen@4.2.1
- @0x/assert@2.1.6
- @0x/asset-buyer@6.1.14
- @0x/asset-swapper@2.0.0
- @0x/base-contract@5.4.0
- @0x/connect@5.0.19
- @0x/contract-addresses@3.2.0
- @0x/contract-artifacts@2.2.2
- @0x/contract-wrappers@12.1.0
- @0x/contracts-gen@1.0.15
- @0x/dev-utils@2.3.3
- ethereum-types@2.1.6
- @0x/fill-scenarios@3.0.19
- @0x/instant@1.0.31
- @0x/json-schemas@4.0.2
- @0x/migrations@4.3.2
- @0x/monorepo-scripts@1.0.37
- @0x/order-utils@8.4.0
- @0x/orderbook@0.0.2
- @0x/sol-compiler@3.1.15
- @0x/sol-coverage@3.0.12
- @0x/sol-doc@2.0.19
- @0x/sol-profiler@3.1.14
- @0x/sol-resolver@2.0.11
- @0x/sol-trace@2.0.20
- @0x/sol-tracing-utils@6.0.19
- @0x/sra-spec@2.0.17
- @0x/subproviders@5.0.4
- @0x/testnet-faucets@1.0.87
- @0x/types@2.4.3
- @0x/typescript-typings@4.3.0
- @0x/utils@4.5.2
- @0x/web3-wrapper@6.0.13
* fix circleci diff
* update changelog
* CI: use a docker image that includes Python
So that tests of abi-gen generating Python can exercise the code being
generated.
* CI fix: disable old yarn permission denied hack
Motivated by CI failure of previous commit.
* CI fix: more resources for test-contracts-ganache
Motivated by CI failure of previous commit.
* CI fix: remove hack of permissions for python libs
Fix for previous CI run's failure of test-python. Apparently we don't
need this in the docker container we've switched to.
* abi-gen/Py: minimum viable test of gen'd code
Ensure the code is parseable by running it through black.
* abi-gen/Py: expand Python linter usage
Make abi-gen filter its output through black, if its available in the
runtime environment. Accordingly, stop having contract_wrappers.py's
setup.py pre_install run black on copied-over files.
Adds Pylint to the list of linters run against test-cli/output.
* abi-gen: re-enable Solidity linter
It was broken, running seemingly cleanly but not actually reading any
files, because it was targetting the wrong folder.
* abi-gen/test-cli/fixtures/sol: fix linter errors
* abi-gen/test-cli: disable pylint blackisted-name
* abi-gen/Py: rm unused var in contracts w/o methods
Remove unused variable from generated wrapper for contracts without any
methods.
* add validateAndSendTransactionAsync to all wrappers
* remove contract-wrappers from @0x/contracts-extensions
* replace error types in contract-wrappers
* upgrade asset-buyer and asset-swapper to contract-wrappers v11
* update website and 0x.js
* remove calldataOptimizationUtils
The update to the fixture contract's artifact added a bunch of
`internalType` stuff. I'm not sure where that came from. Maybe
newly generated by the latest version of solc?
* Install Py packages in dep. order, not in parallel
Install Python packages in dependency order, not in parallel.
* sra_client.py: Add `./setup.py clean`
* Fix python package dependency ordering...
...and include a script to produce the proper ordering.
* sra_client.py: reformat whitespace in doctest
* contract_wrappers.py: don't auto-import wrappers
This was discovered while minimizing CircleCI steps to dianose a problem
with running the Launch Kit Backend in CircleCI.
These classes should be imported via the
zero_ex.contract_wrappers.exchange and
zero_ex.contract_wrappers.erc20_token modules, respectively. We
permitted importing them from just zero_ex.contract_wrappers back when
they were the only wrappers we had, but now that we have so many
different contracts being wrapped, this is just another list to keep
manually updated (which, obviously is error prone, since it slipped
through the cracks already), so it's better to just not support this
type of import.
* abi-gen/Py: doc contract method attributes
Without this, generated documentation was not including the class
members that represent the contract methods, rendering the usage
unclear.
* sra_client.py: disable tests in CI
* abi-gen/Py: strip repeated spaces from devdoc
* contract_wrappers.py: gen docs for all wrappers...
...except for the dummy tokens.
* sra_client.py/test: change launch kit docker image
Previously these teses were using 0xorg/launch-kit-ci, but that was a
one-off thing created just for CI, back before there was a regularly
maintained docker image of Launch Kit.
Changed to use 0xorg/launch-kit-backend since it's regularly
maintained/updated.
Because the -backend image is using a different Linux distribution
(Alpine), the commands used to wait for ganache startup also had to
change.
The tag used, 74bcc39, is provisional due to the pending Issue at
https://github.com/0xProject/0x-launch-kit-backend/issues/73 . When
that issue is resolved, the tag suffix on the imag name should be
removed.
* Migrate from Web3.py 4.x to 5.x
* sra_client.py: checksum address in doctest
Due to problem with launch-kit-backend, documented at
https://github.com/0xProject/0x-launch-kit-backend/issues/73 ,
we need to checksum the makerAddress, in the order retrieved from the
relayer, before filling it, otherwise Web3.py gives this error:
InvalidAddress('Web3.py only accepts checksum addresses. The software
that gave you this non-checksum address should be considered unsafe,
please file it as a bug on their platform. Try using an ENS name
instead. Or, if you must accept lower safety, use
Web3.toChecksumAddress(lower_case_address).',
'0x5409ed021d9299bf6814279a6a1411a7e866a631')
* Update CHANGELOGs
* sra_client.py: make CHANGELOG be REVESE chrono.
Formerly CHANGELOG was in chronological order. Now it's in reverse
chronological order.
* abi-gen/Py: fix missing space in sanitized devdoc
* abi-gen/Py: fix return type for multi-val returns
Methods that return multiple values were broken in two ways. One: a
spurious newline was being injected between the return type and the
colon ending the Python method prototype. Two: the return type was
being generated as just `[TypeA, TypeB]`, whereas it should be
`Tuple[TypeA, TypeB]`.
* abi-gen/Py: fix support for arrays of structs
* abi-gen/Py: FAILING test case nested unrefd struct
When a struct contains another struct, and the inner struct is not
directly referenced by any method interface, wrapper generation is
failing to render a class to represent the inner struct.
This won't fail in CI because at this time CI doesn't run any native
Python tooling to analyze the generated code. Running mypy locally on
the files in this commit produces the following output:
test-cli/output/python/abi_gen_dummy/__init__.py:76: error: Name 'Tuple0x246f9407' is not defined
This problem affects the generation of wrappers for the DutchAuction
contract.
* abi-gen/Py: fix nested unref'd struct failure
* abi-gen/Py: introduce newlines to quiet linter
When generating contracts with long names (eg
CoordinatorRegistryValidator), the `black` reformatter was introducing
these newlines for us, and it was moving the `# type: ignore` comment in
there such that it no longer was on the line it needed to be on.
Introducing these newlines manually (instead of letting black inject
them) allows the linter directive to stay where it needs to be.
* abi-gen/Py: declare tuples in dependency order
* abi-gen/Py: fix support for overloaded methods
* contract_wrappers.py: pylint: permit 2-char args
By default pylint says that 2 characters is too short for an argument
name, but we have some contract methods with 2-character argument names
(eg `to` in `AssetProxyOwner.getTransactionIds()`), so we want to permit
them.
* contract_wrappers.py: include all contracts
* Update CHANGELOGs
* abi-gen: rename variable
* abi-gen: refine comments
* abi-gen/Py: reword tuple class docstring
* first pass at including doc comments
* incorporate suggestions for method comments; add devdoc to dummy contract
* better formatting and persist generated docs as circleci build artifacts
* store artifacts properly
* hanging indent for method params
* git rm unnecessary .gitkeep file
* After all Pytest runs, show short test summary
* abi-gen/Py: facilitate inlining of parameter lists
Effectively, stopped new-lines from being introduced by calls to the
`params` and `typed_params` partials.
* abi-gen: simple Py wrapper test for local dev'ment
* abi-gen/Py: stop gen'ing ValidatorBase
* abi-gen/Py: declare abi() wrapper method in Base
* abi-gen/Py: methods as classes to ease call/sendTx
Represent methods as classes in order to faciliate access to a method's
different operations (call, send_transaction, etc).
* contract_wrappers.py: make Base methods public
Changed some methods on BaseContractWrapper to be public.
* contract_wrappers.py: remove unused method
* contract_wrappers.py: extract method
* abi-gen/Py: inline method
* contract_wrappers.py: fix bug in call()
We were passing transaction parameters through to sendTransaction()
invocations, but not to call() invocations.
* abi-gen/Py: remove `view_only` param to call/tx
Formerly, in the BaseContractWrapper, there was just one function used
for both eth_call and eth_sendTransaction, and you would distinguish
between the two by specifying `view_only=True` when you wanted a call.
This commit defines a method dedicated to executing an eth_call, and
leaves the old method behind, with the `view_only` param removed, to be
used for eth_sendTransaction.
* abi-gen/Py: rename method
* contract_wrappers/Py: simplify web3 func handling
Pass web3 function instance into generated wrapper method class
constructor, rather than having that class obtain it upon each method
call.
Really this is just an elimination of a call to
BaseContractWrapper.contract_instance(), which will be removed
completely in a shortly-upcoming commit.
* contract_wrappers.py: inline method
Inline and remove method BaseContractWrapper.contract_instance().
* contract_wrappers.py: pass Validator to *Method
Pass a ValidatorBase instance into construction of the contract method
classes, *Method, to eliminate another dependency on the containing
contract object, which will be eliminated completely in a
shortly-upcoming commit.
* abi-gen/Py: BaseContractWrapper -> ContractMethod
Change the fundamental thing-to-be-wrapped from the contract to the
method. Since the named method classes were introduced (in a previous
commit), and since the operations contained within the Base are
predominantly focused on supporting method calls more than anything
else, it makes more intuitive sense to provide a base for the methods
than for the contract.
With this change, the method classes no longer require a contract object
to be passed to their constructors. The contract members that the
methods were utilizing are now passed directly to the method
constructor.
* contract_wrappers.py: rename module to bases...
...from _base_contract_wrapper. The old name hasn't made sense since
ValidatorBase was moved into that module, and definitely doesn't make
sense now that the fundamental thing-to-be-wrapped has changed from the
contract to the method. Also renamed to make it public (removed the
leading underscore) since we're generating code that will depend on it.
* abi-gen/Py: clarify call/sendTx docstrings
* abi-gen/Py: adjust whitespace
* contract_wrappers.py: inline method
* abi-gen/Py: rename class ValidatorBase...
...to just Validator. It's in the "bases" module, which provides the
context needed in order to know it's a base class
* python-packages: fix silent failures of ./parallel
* contract_wrappers.py: remove private_key support
Having this present was overcomplicating interfaces. And it was
untested (and not readily working when testing was attempted). And it
only provided a thin layer of convenience, which a client could easily
code up themselves.
* contract_wrappers.py: inline method
* contract_wrappers.py: rm unused member variables
* contract_wrappers.py: rm unnecessary instance var
* abi-gen/Py: add estimate_gas to gen'd methods
* update CHANGELOG.json
