From f2f835591e1e0dae0eb0e6c262784d5eab13800f Mon Sep 17 00:00:00 2001
From: Elena <elena@arenabg.com>
Date: Wed, 8 Feb 2023 09:04:17 +0200
Subject: [PATCH] Code coverage improvements (#656)

* Add check for coverage threshold

* Rename WrapEth foundry test file to .t.sol
---
 .github/workflows/ci.yml                               | 9 ++++++++-
 contracts/zero-ex/tests/{WrapEth.sol => WrapEth.t.sol} | 0
 contracts/zero-ex/tests/forked/WrapEthTest.t.sol       | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)
 rename contracts/zero-ex/tests/{WrapEth.sol => WrapEth.t.sol} (100%)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f39e0b116f..858ed3566a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -98,7 +98,7 @@ jobs:
             - name: Run Forge coverage
               working-directory: contracts/zero-ex
               run: |
-                  forge coverage --report lcov
+                  forge coverage --report summary --report lcov
 
             - name: Upload the coverage report to Coveralls
               uses: coverallsapp/github-action@master
@@ -106,3 +106,10 @@ jobs:
                   github-token: ${{ secrets.GITHUB_TOKEN }}
                   base-path: ./contracts/zero-ex/
                   path-to-lcov: ./contracts/zero-ex/lcov.info
+
+            - name: Check coverage threshold
+              uses: VeryGoodOpenSource/very_good_coverage@v2
+              with:
+                  path: ./contracts/zero-ex/lcov.info
+                  min_coverage: 6.98
+                  exclude: '**/tests'
diff --git a/contracts/zero-ex/tests/WrapEth.sol b/contracts/zero-ex/tests/WrapEth.t.sol
similarity index 100%
rename from contracts/zero-ex/tests/WrapEth.sol
rename to contracts/zero-ex/tests/WrapEth.t.sol
diff --git a/contracts/zero-ex/tests/forked/WrapEthTest.t.sol b/contracts/zero-ex/tests/forked/WrapEthTest.t.sol
index 956034e496..8923392364 100644
--- a/contracts/zero-ex/tests/forked/WrapEthTest.t.sol
+++ b/contracts/zero-ex/tests/forked/WrapEthTest.t.sol
@@ -29,7 +29,7 @@ import "src/transformers/bridges/BridgeProtocols.sol";
 import "src/transformers/bridges/EthereumBridgeAdapter.sol";
 import "src/IZeroEx.sol";
 
-contract WrapEth is Test, ForkUtils, TestUtils {
+contract WrapEthTest is Test, ForkUtils, TestUtils {
     DeployZeroEx.ZeroExDeployed zeroExDeployed;
 
     function setUp() public {