From ec08715090f060f9a1cf76b2b36b2ae5b94e9b03 Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Wed, 16 Sep 2020 17:37:31 -0400 Subject: [PATCH] Streamline isMakerBlacklisted() logic --- .../asset-swapper/src/utils/rfq_maker_blacklist.ts | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/packages/asset-swapper/src/utils/rfq_maker_blacklist.ts b/packages/asset-swapper/src/utils/rfq_maker_blacklist.ts index b0cf6b9664..5be7239daa 100644 --- a/packages/asset-swapper/src/utils/rfq_maker_blacklist.ts +++ b/packages/asset-swapper/src/utils/rfq_maker_blacklist.ts @@ -24,15 +24,10 @@ export class RfqMakerBlacklist { } } public isMakerBlacklisted(makerUrl: string): boolean { - if (this._makerBlacklistedUntilDate.hasOwnProperty(makerUrl)) { - if (this._makerBlacklistedUntilDate[makerUrl] > Date.now()) { - delete this._makerBlacklistedUntilDate[makerUrl]; - return false; - } else { - return true; - } - } else { - return false; + const now = Date.now(); + if (now > this._makerBlacklistedUntilDate[makerUrl]) { + delete this._makerBlacklistedUntilDate[makerUrl]; } + return this._makerBlacklistedUntilDate[makerUrl] > now; } }