From e738743c893f2c1dfda37ad4d88f367933204f5a Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Fri, 28 Aug 2020 15:52:15 -0400 Subject: [PATCH] asset-swapper: ensure takerAddress for indiciative Ensure the presence of a taker address query parameter in the request to market maker endpoints for indicative RFQ-T quotes. Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2684#pullrequestreview-477242367 --- packages/asset-swapper/src/utils/quote_requestor.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/asset-swapper/src/utils/quote_requestor.ts b/packages/asset-swapper/src/utils/quote_requestor.ts index d2babde49d..3826c2b798 100644 --- a/packages/asset-swapper/src/utils/quote_requestor.ts +++ b/packages/asset-swapper/src/utils/quote_requestor.ts @@ -214,6 +214,10 @@ export class QuoteRequestor { ): Promise { const _opts: RfqtRequestOpts = { ...constants.DEFAULT_RFQT_REQUEST_OPTS, ...options }; + if (!_opts.takerAddress) { + _opts.takerAddress = constants.NULL_ADDRESS; + } + const responsesWithStringInts = await this._getQuotesAsync( // not yet BigNumber makerAssetData, takerAssetData,