crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[asset-swapper] Change Exchange sell to marketSellOrdersFillOrKill (#2450)

Browse Source 
* Change Exchange sell to marketSellOrdersFillOrKill

* Update Changelog
This commit is contained in:
Jacob Evans 2020-01-22 18:25:09 +10:00 committed by GitHub
parent ce04d3ce41
commit e436673304
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/asset-swapper/CHANGELOG.json
View File

@ -21,6 +21,10 @@
{
"note": "Compute more accurate best quote price",
"pr": 2427
},
{
"note": "Change Exchange sell function from `marketSellOrdersNoThrow` to `marketSellOrdersFillOrKill`",
"pr": 2450
}
]
},

2
packages/asset-swapper/src/quote_consumers/exchange_swap_quote_consumer.ts
View File

@ -51,7 +51,7 @@ export class ExchangeSwapQuoteConsumer implements SwapQuoteConsumerBase {
.getABIEncodedTransactionData();
} else {
calldataHexString = this._exchangeContract
.marketSellOrdersNoThrow(orders, quote.takerAssetFillAmount, signatures)
.marketSellOrdersFillOrKill(orders, quote.takerAssetFillAmount, signatures)
.getABIEncodedTransactionData();
}