crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove TODOs that will not be addressed

Browse Source
This commit is contained in:
Amir Bandeali 2018-09-02 10:39:22 -07:00
parent f6b6619c08
commit e34b1f2f8b
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/contracts/src/2.0.0/extensions/Forwarder/MixinExchangeWrapper.sol vendored
View File

@ -60,7 +60,7 @@ contract MixinExchangeWrapper is
// Call `fillOrder` and handle any exceptions gracefully // Call `fillOrder` and handle any exceptions gracefully
assembly { assembly {
let success := call( let success := call(
gas, // forward all gas, TODO: look into gas consumption of assert/throw gas, // forward all gas
exchange, // call address of Exchange contract exchange, // call address of Exchange contract
0, // transfer 0 wei 0, // transfer 0 wei
add(fillOrderCalldata, 32), // pointer to start of input (skip array length in first 32 bytes) add(fillOrderCalldata, 32), // pointer to start of input (skip array length in first 32 bytes)

2
packages/contracts/src/2.0.0/protocol/Exchange/MixinWrapperFunctions.sol vendored
View File

@ -81,7 +81,7 @@ contract MixinWrapperFunctions is
// Delegate to `fillOrder` and handle any exceptions gracefully // Delegate to `fillOrder` and handle any exceptions gracefully
assembly { assembly {
let success := delegatecall( let success := delegatecall(
gas, // forward all gas, TODO: look into gas consumption of assert/throw gas, // forward all gas
address, // call address of this contract address, // call address of this contract
add(fillOrderCalldata, 32), // pointer to start of input (skip array length in first 32 bytes) add(fillOrderCalldata, 32), // pointer to start of input (skip array length in first 32 bytes)
mload(fillOrderCalldata), // length of input mload(fillOrderCalldata), // length of input

1
packages/contracts/src/2.0.0/protocol/Exchange/libs/LibMath.sol vendored
View File

@ -246,7 +246,6 @@ contract LibMath is
numerator, numerator,
denominator denominator
); );
// TODO: safeMod
remainder = safeSub(denominator, remainder) % denominator; remainder = safeSub(denominator, remainder) % denominator;
isError = safeMul(1000, remainder) >= safeMul(numerator, target); isError = safeMul(1000, remainder) >= safeMul(numerator, target);
return isError; return isError;