crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/asset-swapper: rename getMinBuyAmount() to getSwapMinBuyAmount()` and export for use in API.

Browse Source
This commit is contained in:
Lawrence Forman 2020-09-23 17:12:24 -04:00
parent 99de5a3814
commit de7f1fc207
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/asset-swapper/src/index.ts
View File

@ -84,6 +84,7 @@ export {
export { artifacts } from './artifacts'; export { artifacts } from './artifacts';
export { InsufficientAssetLiquidityError } from './errors'; export { InsufficientAssetLiquidityError } from './errors';
export { SwapQuoteConsumer } from './quote_consumers/swap_quote_consumer'; export { SwapQuoteConsumer } from './quote_consumers/swap_quote_consumer';
export { getSwapMinBuyAmount } from './quote_consumers/utils';
export { SwapQuoter } from './swap_quoter'; export { SwapQuoter } from './swap_quoter';
export { export {
AffiliateFee, AffiliateFee,

4
packages/asset-swapper/src/quote_consumers/exchange_proxy_swap_quote_consumer.ts
View File

@ -30,7 +30,7 @@ import { assert } from '../utils/assert';
import { ERC20BridgeSource, UniswapV2FillData } from '../utils/market_operation_utils/types'; import { ERC20BridgeSource, UniswapV2FillData } from '../utils/market_operation_utils/types';
import { getTokenFromAssetData } from '../utils/utils'; import { getTokenFromAssetData } from '../utils/utils';
import { getMinBuyAmount } from './utils'; import { getSwapMinBuyAmount } from './utils';
// tslint:disable-next-line:custom-no-magic-numbers // tslint:disable-next-line:custom-no-magic-numbers
const MAX_UINT256 = new BigNumber(2).pow(256).minus(1); const MAX_UINT256 = new BigNumber(2).pow(256).minus(1);
@ -95,7 +95,7 @@ export class ExchangeProxySwapQuoteConsumer implements SwapQuoteConsumerBase {
const sellToken = getTokenFromAssetData(quote.takerAssetData); const sellToken = getTokenFromAssetData(quote.takerAssetData);
const buyToken = getTokenFromAssetData(quote.makerAssetData); const buyToken = getTokenFromAssetData(quote.makerAssetData);
const sellAmount = quote.worstCaseQuoteInfo.totalTakerAssetAmount; const sellAmount = quote.worstCaseQuoteInfo.totalTakerAssetAmount;
let minBuyAmount = getMinBuyAmount(quote); let minBuyAmount = getSwapMinBuyAmount(quote);
// VIP routes. // VIP routes.
if (isDirectUniswapCompatible(quote, optsWithDefaults)) { if (isDirectUniswapCompatible(quote, optsWithDefaults)) {

2
packages/asset-swapper/src/quote_consumers/utils.ts
View File

@ -9,7 +9,7 @@ import { MarketOperation, SwapQuote } from '../types';
* `worstCaseQuoteInfo.makerAssetAmount` because that does not stop at * `worstCaseQuoteInfo.makerAssetAmount` because that does not stop at
* maximum slippage. * maximum slippage.
*/ */
export function getMinBuyAmount(quote: SwapQuote): BigNumber { export function getSwapMinBuyAmount(quote: SwapQuote): BigNumber {
// Infer the allowed maker asset slippage from the orders. // Infer the allowed maker asset slippage from the orders.
const totalOrderMakerAssetAmount = BigNumber.sum(...quote.orders.map(o => o.makerAssetAmount)); const totalOrderMakerAssetAmount = BigNumber.sum(...quote.orders.map(o => o.makerAssetAmount));
const totalFillMakerAssetAmount = const totalFillMakerAssetAmount =